Skip to content

Conversation

@joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Aug 16, 2022

Signed-off-by: Joshua Li [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner August 16, 2022 17:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #765 (8ab3ac5) into main (9f602c3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #765   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
  Complexity     2910     2910           
=========================================
  Files           287      287           
  Lines          7831     7831           
  Branches        571      571           
=========================================
  Hits           7428     7428           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes!

@dai-chen dai-chen requested a review from a team August 16, 2022 22:40
@joshuali925 joshuali925 merged commit 23a4a88 into opensearch-project:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants