Skip to content

Conversation

@MitchellGale
Copy link
Contributor

Description

Adds documentation to datatypes.rst regarding implementation and functionality for double quotes being used as escape characters in some situations. See below table for example of implementation. See https://dev.mysql.com/doc/refman/8.0/en/string-literals.html mysql documentation.

+-----------+-----------+-------------+-------------+---------------+---------------+
| 'hello'   | "world"   | '"hello"'   | "'world'"   | '''hello'''   | """world"""   |
|-----------+-----------+-------------+-------------+---------------+---------------|
| hello     | world     | "hello"     | 'world'     | 'hello'       | "world"       |
+-----------+-----------+-------------+-------------+---------------+---------------+

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MitchellGale MitchellGale requested a review from a team as a code owner August 3, 2022 23:21
@MitchellGale MitchellGale changed the title Integ double quote documentation Adding documentation about double quote implementation Aug 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (1df89e3) to head (061dd67).
⚠️ Report is 1064 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #723   +/-   ##
=========================================
  Coverage     97.76%   97.76%           
  Complexity     2880     2880           
=========================================
  Files           276      276           
  Lines          7077     7077           
  Branches        447      447           
=========================================
  Hits           6919     6919           
  Misses          157      157           
  Partials          1        1           
Flag Coverage Δ
sql-engine 97.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dai-chen
dai-chen previously approved these changes Aug 3, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@penghuo
Copy link
Collaborator

penghuo commented Aug 5, 2022

CI failed?
Could you merge the commits in case there is only one file change?

@joshuali925
Copy link
Member

I'll merge in, CI failing should be irrelevant to this PR

@joshuali925 joshuali925 merged commit 921a28c into opensearch-project:main Aug 8, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the Integ-doubleQuote_Documentation branch September 13, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants