Skip to content

Conversation

@dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Jul 13, 2022

Description

Following https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#addition to update maintainer list with nominees. The maintainers have voted and agreed to this nomination and the nominee confirmed their interest in becoming co-maintainer.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen self-assigned this Jul 13, 2022
@dai-chen dai-chen force-pushed the add-bq-maintainer branch from 743a9cb to 1292df3 Compare July 13, 2022 18:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #687 (1292df3) into main (8d9b459) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #687   +/-   ##
=========================================
  Coverage     94.74%   94.74%           
  Complexity     2857     2857           
=========================================
  Files           283      283           
  Lines          7676     7676           
  Branches        561      561           
=========================================
  Hits           7273     7273           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9b459...1292df3. Read the comment docs.

acarbonetto
acarbonetto previously approved these changes Jul 13, 2022
@dai-chen dai-chen marked this pull request as ready for review July 14, 2022 17:44
@dai-chen dai-chen requested a review from a team as a code owner July 14, 2022 17:44
@dai-chen dai-chen requested a review from joshuali925 July 14, 2022 17:45
acarbonetto
acarbonetto previously approved these changes Jul 14, 2022
@dai-chen
Copy link
Collaborator Author

!!! NOTE !!!: Blocking this PR until we finish the first and second step in https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#addition

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen merged commit 10fe75f into opensearch-project:main Sep 8, 2022
@dai-chen dai-chen deleted the add-bq-maintainer branch September 8, 2022 17:36
@dai-chen
Copy link
Collaborator Author

dai-chen commented Sep 8, 2022

@dblock As the final step below, do you know how can I find repo admin to change the permission for the new maintainers?

The repo admin adjusts the new maintainer’s permissions accordingly, and merges the pull request.

@dblock
Copy link
Member

dblock commented Sep 12, 2022

@dai-chen organizational owners are the only ones that can add external contributors, @CEHENKLE please help?

We have an internal tool whereas those with admin access to repos can act on behalf of the organizational owner to invite external collaborators. I've invited @MaxKsyunz and @Yury-Fridlyand so we should be all set now.

@dblock
Copy link
Member

dblock commented Sep 12, 2022

Screen Shot 2022-09-12 at 1 46 03 PM
Screen Shot 2022-09-12 at 1 46 07 PM

@dblock
Copy link
Member

dblock commented Sep 12, 2022

FYI @anirudha has the same level of access as me here, for next time

@dai-chen
Copy link
Collaborator Author

FYI @anirudha has the same level of access as me here, for next time

Good to know that. Thanks for the help this time!

@dblock dblock changed the title Update maintainer list Add @MaxKsyunz and @Yury-Fridlyand to MAINTAINERS Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants