-
Notifications
You must be signed in to change notification settings - Fork 181
Migrate workbench to OpenSearch Dashboards #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
2db19a8
59dd41f
4d7cc7b
3b2032b
299eb14
eb0b464
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,8 @@ name: SQL Workbench Test and Build | |
| on: [pull_request, push] | ||
|
|
||
| env: | ||
| PLUGIN_NAME: opendistroQueryWorkbenchKibana | ||
| OD_VERSION: 1.13.0.0 | ||
| PLUGIN_NAME: opendistroQueryWorkbenchOpenSearchDashboards | ||
| OD_VERSION: 1.15.0.0 | ||
|
|
||
| jobs: | ||
|
|
||
|
|
@@ -15,36 +15,36 @@ jobs: | |
| steps: | ||
| - name: Checkout Plugin | ||
| uses: actions/checkout@v1 | ||
| - name: Checkout Kibana | ||
| - name: Checkout OpenSearch Dashboards | ||
| uses: actions/checkout@v1 | ||
| with: | ||
| repository: elastic/kibana | ||
| ref: v7.10.2 | ||
| path: sql/kibana | ||
| path: sql/OpenSearch-Dashboards | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think paths should remain lowercase. + below many
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even though the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right. In hindsight maybe we should have made repo names lowercase, but YOLO. |
||
| - name: Setup Node | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: '10.23.1' | ||
| - name: Move Workbench to Plugins Dir | ||
| run: | | ||
| mv workbench kibana/plugins | ||
| - name: Kibana Plugin Bootstrap | ||
| mv workbench OpenSearch-Dashboards/plugins | ||
| - name: OpenSearch Dashboards Plugin Bootstrap | ||
| uses: nick-invision/retry@v1 | ||
| with: | ||
| timeout_minutes: 60 | ||
| max_attempts: 3 | ||
| command: cd kibana/plugins/workbench; yarn kbn bootstrap | ||
| command: cd OpenSearch-Dashboards/plugins/workbench; yarn osd bootstrap | ||
| - name: Test | ||
| run: | | ||
| cd kibana/plugins/workbench | ||
| cd OpenSearch-Dashboards/plugins/workbench | ||
| yarn test:jest | ||
| - name: Build Artifact | ||
| run: | | ||
| cd kibana/plugins/workbench | ||
| cd OpenSearch-Dashboards/plugins/workbench | ||
| yarn build | ||
| mv ./build/*.zip ./build/${{ env.PLUGIN_NAME }}-${{ env.OD_VERSION }}.zip | ||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v1 | ||
| with: | ||
| name: workbench | ||
| path: kibana/plugins/workbench/build | ||
| path: OpenSearch-Dashboards/plugins/workbench/build | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| Open Distro for Elasticsearch SQL Kibana Plugin | ||
| OpenSearch Dashboards SQL Plugin | ||
| Copyright 2018-2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Open Distro for Elasticsearch Query Workbench | ||
| # OpenSearch Dashboards Query Workbench | ||
|
|
||
| The Open Distro for Elasticsearch Query Workbench enables you to query your Elasticsearch data using either SQL or PPL syntax from a dedicated Kibana UI. You can download your query results data in JSON, JDBC, CSV and raw text formats. | ||
| The OpenSearch Dashboards Query Workbench enables you to query your OpenSearch data using either SQL or PPL syntax from a dedicated OpenSearch Dashboards UI. You can download your query results data in JSON, JDBC, CSV and raw text formats. | ||
|
|
||
|
|
||
| ## Documentation | ||
|
|
@@ -10,29 +10,29 @@ Please see our technical [documentation](https://opendistro.github.io/for-elasti | |
|
|
||
| ## Setup | ||
|
|
||
| 1. Download Elasticsearch for the version that matches the [Kibana version specified in package.json](./package.json#L8). | ||
| 1. Download and install the most recent version of [Open Distro for Elasticsearch SQL plugin](https://github.com/opendistro-for-elasticsearch/sql). | ||
| 1. Download the Kibana source code for the [version specified in package.json](./package.json#L8) you want to set up. | ||
| 1. Download OpenSearch for the version that matches the [OpenSearch Dashboards version specified in package.json](./package.json#L8). | ||
| 1. Download and install the most recent version of [OpenSearch SQL plugin](https://github.com/opensearch-project/sql#open-distro-for-elasticsearch-sql). | ||
| 1. Download the OpenSearch Dashboards source code for the [version specified in package.json](./package.json#L8) you want to set up. | ||
|
|
||
| See the [Kibana contributing guide](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#setting-up-your-development-environment) for more instructions on setting up your development environment. | ||
| See the [OpenSearch Dashboards contributing guide](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md) to get started. | ||
|
|
||
| 1. Change your node version to the version specified in `.node-version` inside the Kibana root directory. | ||
| 1. cd into the Kibana source code directory. | ||
| 1. Change your node version to the version specified in `.node-version` inside the OpenSearch Dashboards root directory. | ||
| 1. cd into the OpenSearch Dashboards source code directory. | ||
| 1. Check out this package from version control into the `plugins` directory. | ||
| ``` | ||
| git clone [email protected]:opendistro-for-elasticsearch/sql.git plugins --no-checkout | ||
| git clone [email protected]:opensearch-project/sql.git plugins --no-checkout | ||
| cd plugins | ||
| echo 'workbench/*' >> .git/info/sparse-checkout | ||
| git config core.sparseCheckout true | ||
| git checkout master | ||
| git checkout main | ||
| ``` | ||
| 6. Run `yarn kbn bootstrap` inside `kibana/plugins/workbench`. | ||
| 6. Run `yarn osd bootstrap` inside `OpenSearch-Dashboards/plugins/workbench`. | ||
davidcui1225 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| Ultimately, your directory structure should look like this: | ||
|
|
||
| ```md | ||
| . | ||
| ├── kibana | ||
| ├── OpenSearch-Dashboards | ||
davidcui1225 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| │ └── plugins | ||
| │ └── workbench | ||
| ``` | ||
|
|
@@ -49,21 +49,21 @@ Example output: `./build/opendistro-query-workbench-*.zip` | |
|
|
||
| - `yarn start` | ||
|
|
||
| Starts Kibana and includes this plugin. Kibana will be available on `localhost:5601`. | ||
| Starts OpenSearch Dashboards and includes this plugin. OpenSearch Dashboards will be available on `localhost:5601`. | ||
|
|
||
| - `NODE_PATH=../../node_modules yarn test:jest` | ||
|
|
||
| Runs the plugin tests. | ||
|
|
||
|
|
||
| ## Contributing to Open Distro for Elasticsearch Query Workbench | ||
| ## Contributing to OpenSearch SQL Workbench | ||
|
|
||
| - Refer to [CONTRIBUTING.md](./CONTRIBUTING.md). | ||
| - Since this is a workbench, it can be useful to review the [Kibana contributing guide](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md) alongside the documentation around [workbenchs](https://www.elastic.co/guide/en/kibana/master/kibana-plugins.html) and [plugin development](https://www.elastic.co/guide/en/kibana/master/plugin-development.html). | ||
| - We welcome you to get involved in development, documentation, testing the OpenSearch SQL Workbench plugin. See our [CONTRIBUTING.md](./CONTRIBUTING.md) and join in. | ||
|
|
||
| ## Bugs, Enhancements or Questions | ||
|
|
||
| Please file an issue to report any bugs you may find, enhancements you may need or questions you may have [here](https://github.com/opendistro-for-elasticsearch/sql/issues). | ||
| Please file an issue to report any bugs you may find, enhancements you may need or questions you may have [here](https://github.com/opensearch-project/sql/issues). | ||
|
|
||
| ## License | ||
|
|
||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "id": "opendistroQueryWorkbenchOpenSearchDashboards", | ||
davidcui1225 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "version": "1.15.0.0", | ||
| "opensearchDashboardsVersion": "7.10.2", | ||
| "server": true, | ||
| "ui": true, | ||
| "requiredPlugins": ["navigation"], | ||
| "optionalPlugins": [] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,21 @@ | ||
| { | ||
| "name": "opendistro-query-workbench", | ||
| "version": "1.13.0.0", | ||
| "version": "1.15.0.0", | ||
| "description": "Query Workbench", | ||
| "main": "index.js", | ||
| "license": "Apache-2.0", | ||
| "homepage": "https://github.com/opendistro-for-elasticsearch/sql/tree/master/workbench", | ||
| "kibana": { | ||
| "homepage": "https://github.com/opensearch-project/sql/tree/main/workbench", | ||
| "opensearchDashboards": { | ||
| "version": "7.10.2", | ||
| "templateVersion": "6.3.3" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/opendistro-for-elasticsearch/sql/tree/master/workbench" | ||
| "url": "https://github.com/opensearch-project/sql/tree/main/workbench" | ||
| }, | ||
| "scripts": { | ||
| "kbn": "node ../../scripts/kbn", | ||
| "osd": "node ../../scripts/osd", | ||
| "opensearch": "node ../../scripts/opensearch", | ||
| "lint": "tslint .", | ||
| "start": "plugin-helpers start", | ||
| "test:server": "plugin-helpers test:server", | ||
|
|
@@ -28,7 +29,6 @@ | |
| "react-double-scrollbar": "^0.0.15" | ||
| }, | ||
| "devDependencies": { | ||
| "@elastic/eslint-import-resolver-kibana": "link:../../packages/kbn-eslint-import-resolver-kibana", | ||
| "@types/hapi-latest": "npm:@types/[email protected]", | ||
| "@types/react-router-dom": "^5.1.5", | ||
| "cypress": "^5.0.0", | ||
|
|
@@ -57,8 +57,6 @@ | |
| "**/@types/react-dom": "^16.0.5", | ||
| "**/@types/react-router-dom": "^4.3.1", | ||
| "eslint-utils": "^2.0.0", | ||
| "**/@types/react": "16.3.14", | ||
| "lodash": "^4.17.21", | ||
| "ssri": "8.0.1" | ||
| "**/@types/react": "16.3.14" | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.