Skip to content

Remove explicit node version for workbench #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuali925 merged 3 commits into from
Apr 22, 2022
Merged

Remove explicit node version for workbench #588

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
201d728
Remove explicit node version for workbench
joshuali925 Apr 22, 2022
2b2d381
Use nvmrc
joshuali925 Apr 22, 2022
264d9c0
Update nvmrc path
joshuali925 Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/sql-workbench-test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ jobs:
path: sql/OpenSearch-Dashboards

- name: Setup Node
Copy link

@tmarkley tmarkley Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the Dashboards .nvmrc file? Similar to what we do in Dashboards: https://github.com/tmarkley/OpenSearch-Dashboards/blob/c67b31e732995207ae432f24b393c902ec326b96/.github/workflows/build_and_test_workflow.yml#L32-L36

Copy link
Member Author

@joshuali925 joshuali925 Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, updated

uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: '14.18.2'
node-version-file: ".nvmrc"
Copy link

@tmarkley tmarkley Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to point to the OpenSearch Dashboards directory to get this to work.

Copy link

@tmarkley tmarkley Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it :)

registry-url: 'https://registry.npmjs.org'

- name: Move Workbench to Plugins Dir
run: |
Expand Down
4 changes: 0 additions & 4 deletions workbench/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@
"tslint-config-prettier": "^1.18.0",
"tslint-plugin-prettier": "^2.0.1"
},
"engines": {
"node": "14.18.2",
"yarn": "^1.21.1"
},
"resolutions": {
"**/@types/node": "10.12.27",
"@types/react": "16.3.14",
Expand Down