[BugFix] Fix the bug when boolean comparison condition is simplifed to field #5071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Songkan Tang <songkant@amazon.com>
Contributor
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR adds support for pushing down boolean field equality comparisons as term queries within filter predicates, enabling query optimization when filters combine boolean field conditions with other operators like query_string. Changes
Sequence DiagramsequenceDiagram
participant Client
participant PredicateAnalyzer
participant NamedFieldExpression
participant SimpleQueryExpression
participant DSLGenerator
Client->>PredicateAnalyzer: analyzeExpression(filter with boolean field)
PredicateAnalyzer->>NamedFieldExpression: isBooleanType() check
NamedFieldExpression-->>PredicateAnalyzer: true (boolean field detected)
PredicateAnalyzer->>SimpleQueryExpression: isTrue() / isFalse()
SimpleQueryExpression->>DSLGenerator: create TermQuery(field, true/false)
DSLGenerator-->>SimpleQueryExpression: TermQuery object
SimpleQueryExpression-->>PredicateAnalyzer: QueryExpression with term
PredicateAnalyzer->>DSLGenerator: combine with other filters (AND/OR)
DSLGenerator-->>PredicateAnalyzer: BoolQuery with must clauses
PredicateAnalyzer-->>Client: optimized DSL with pushed-down boolean term
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
songkant-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
Signed-off-by: Songkan Tang <songkant@amazon.com>
penghuo
reviewed
Jan 26, 2026
| Content-Type: 'application/json' | ||
| ppl: | ||
| body: | ||
| query: source=test-boolean | where is_internal=true | fields name |
Collaborator
There was a problem hiding this comment.
Using failed query source=test url=http | where is_internal=true
in #5054
Comment on lines
+582
to
+586
| // Handle NOT(IS_TRUE(boolean_field)) - convert to term query with false value | ||
| // This covers cases where IS_TRUE was explicitly applied | ||
| if (expr instanceof SimpleQueryExpression simpleExpr && simpleExpr.isBooleanFieldIsTrue()) { | ||
| return QueryExpression.create(simpleExpr.rel).isFalse(); | ||
| } |
Collaborator
There was a problem hiding this comment.
- (NOT boolean_field = true) will return fields include ture, null and missing fields
- but boolean_field=false only return fields has false value.
| // generate a term query with value true. | ||
| // When called on an already-evaluated predicate (builder already set), | ||
| // return as-is. | ||
| if (builder == null) { |
Collaborator
There was a problem hiding this comment.
Is it possible to override isTrue and not API for NamedFieldExpression instead of changing SimpleQueryExpression?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug discovered in #5054. See root cause description in #5054 (comment)
Related Issues
Resolves #5054
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.