Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Jan 12, 2026

Description

Increment version to 3.5.0

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated OpenSearch version to 3.5.0-SNAPSHOT
    • Standardized Jackson annotation dependency versions across all modules for consistency

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

OpenSearch version updated from 3.4.0-SNAPSHOT to 3.5.0-SNAPSHOT in the root build configuration. Jackson annotations dependency version references are normalized across multiple Gradle build files to use a dedicated versions.jackson_annotations variable instead of the generic versions.jackson.

Changes

Cohort / File(s) Summary
OpenSearch version bump
build.gradle
Default OpenSearch version updated from 3.4.0-SNAPSHOT to 3.5.0-SNAPSHOT in buildscript.ext block.
Jackson annotations version normalization
build.gradle, core/build.gradle, integ-test/build.gradle, plugin/build.gradle
Dependency declarations and forced version resolutions for com.fasterxml.jackson.core:jackson-annotations updated to reference ${versions.jackson_annotations} instead of ${versions.jackson} or ${Versions.jackson}.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Increment version to 3.5.0' directly matches the main change in the PR: updating OpenSearch version from 3.4.0-SNAPSHOT to 3.5.0-SNAPSHOT in build.gradle.
Description check ✅ Passed The description states 'Increment version to 3.5.0' which aligns with the primary change of updating the default OpenSearch version in the build files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74b2fb3 and acd22e4.

📒 Files selected for processing (4)
  • build.gradle
  • core/build.gradle
  • integ-test/build.gradle
  • plugin/build.gradle
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: opensearch-project/sql PR: 0
File: .rules/REVIEW_GUIDELINES.md:0-0
Timestamp: 2025-12-02T17:27:55.938Z
Learning: Applies to **/*.java : Maintain Java 11 compatibility when possible for OpenSearch 2.x
📚 Learning: 2025-12-02T17:27:55.938Z
Learnt from: CR
Repo: opensearch-project/sql PR: 0
File: .rules/REVIEW_GUIDELINES.md:0-0
Timestamp: 2025-12-02T17:27:55.938Z
Learning: Verify changes with `./gradlew :integ-test:integTest` before merge

Applied to files:

  • integ-test/build.gradle
📚 Learning: 2025-12-02T17:27:55.938Z
Learnt from: CR
Repo: opensearch-project/sql PR: 0
File: .rules/REVIEW_GUIDELINES.md:0-0
Timestamp: 2025-12-02T17:27:55.938Z
Learning: Applies to **/*.java : Maintain Java 11 compatibility when possible for OpenSearch 2.x

Applied to files:

  • build.gradle
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (30)
  • GitHub Check: security-it-linux (21)
  • GitHub Check: security-it-linux (25)
  • GitHub Check: build-linux (21, doc)
  • GitHub Check: build-linux (21, integration)
  • GitHub Check: build-linux (25, doc)
  • GitHub Check: build-linux (25, integration)
  • GitHub Check: build-linux (21, unit)
  • GitHub Check: build-linux (25, unit)
  • GitHub Check: bwc-tests-full-restart (25)
  • GitHub Check: bwc-tests-full-restart (21)
  • GitHub Check: bwc-tests-rolling-upgrade (25)
  • GitHub Check: bwc-tests-rolling-upgrade (21)
  • GitHub Check: security-it-windows-macos (windows-latest, 25)
  • GitHub Check: security-it-windows-macos (windows-latest, 21)
  • GitHub Check: security-it-windows-macos (macos-14, 25)
  • GitHub Check: security-it-windows-macos (macos-14, 21)
  • GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, unit)
  • GitHub Check: build-windows-macos (macos-14, 25, doc)
  • GitHub Check: build-windows-macos (macos-14, 21, unit)
  • GitHub Check: build-windows-macos (macos-14, 21, doc)
  • GitHub Check: build-windows-macos (macos-14, 25, unit)
  • GitHub Check: build-windows-macos (macos-14, 21, integration)
  • GitHub Check: build-windows-macos (macos-14, 25, integration)
  • GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, integration)
  • GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, integration)
  • GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, unit)
  • GitHub Check: CodeQL-Scan (java)
  • GitHub Check: Update draft release notes
  • GitHub Check: test-sql-cli-integration (21)
  • GitHub Check: WhiteSource Security Check
🔇 Additional comments (5)
build.gradle (2)

9-9: LGTM!

Version bump to 3.5.0-SNAPSHOT is correct for the release increment.


149-149: Verified: versions.jackson_annotations is properly defined in OpenSearch build tools.

The variable is defined in OpenSearch's buildSrc/version.properties and correctly imported via the opensearch.java plugin. The change to use this dedicated version variable for jackson-annotations is consistent with how other Jackson modules are managed (jackson-databind, jackson, etc.).

plugin/build.gradle (1)

160-160: LGTM!

The dependency update is consistent with the jackson-annotations version normalization across the project. Using versions.jackson_annotations aligns with how jackson-databind uses versions.jackson_databind on line 159.

integ-test/build.gradle (1)

182-182: LGTM!

The resolution strategy update is consistent with the project-wide normalization of jackson-annotations versioning.

Based on learnings, please verify with ./gradlew :integ-test:integTest before merge to ensure the dependency changes don't introduce any issues.

core/build.gradle (1)

56-56: LGTM!

The dependency update follows the established pattern where each Jackson module uses its appropriate version variable (jackson for core/dataformats, jackson_databind for databind, and now jackson_annotations for annotations).


Comment @coderabbitai help to get the list of available commands and usage tips.

@cwperks cwperks added the maintenance Improves code quality, but not the product label Jan 12, 2026
@Swiddis Swiddis merged commit e0f428b into opensearch-project:main Jan 12, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improves code quality, but not the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants