-
Notifications
You must be signed in to change notification settings - Fork 181
Add version numbers for all settings in the docs #5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
📝 WalkthroughSummary by CodeRabbitDocumentation
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughDocumentation files for settings add version metadata blocks to settings entries across two formats. Version information is introduced as structured subsections or blocks, with one reference value updated from 3.4.0 to 3.4. No functional or behavioral changes to the settings themselves. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (1)docs/**/*.rst⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📚 Learning: 2025-12-11T05:27:39.856ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
🔇 Additional comments (3)
Comment |
LantaoJin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you manually checked all commits to identify the introduce versions, did you? I am not sure should reviewer check them again. I approve this changes without checking the specific version values.
RyanL1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, and I was wondering if there is also a similar way to handle the deprecation of a config?
Description
While debugging an oncall ticket, having the version number specified for plugins.query.buckets was super useful. I was so inspired I wanted to do it with all the rest of our settings, too.
Related Issues
Minor inconveniences with finding the version in which a config became available.
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.