generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 181
Prune old in operator push down rules #4992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8bd9882
Fix NPE in AggregateAnalyzer
qianheng-aws c9fef08
Try prune old in our optimization rules
qianheng-aws 538cb84
Merge remote-tracking branch 'refs/remotes/origin/main' into pruneOld
qianheng-aws f872b8a
Try prune old in our optimization rules
qianheng-aws ff5329c
Support prune old for AggregateIndexScanRule
qianheng-aws fde4937
Merge remote-tracking branch 'refs/remotes/origin/main' into pruneOld
qianheng-aws 4879aee
Merge main and refactor DedupPushdownRule
qianheng-aws fdd1d16
Fix explain IT
qianheng-aws 0f089fd
Fix explain IT
qianheng-aws 2a87ec8
Fix clickbench IT
qianheng-aws dd75c1e
SpotlessApply
qianheng-aws 476d649
Fix dedup explain it
qianheng-aws 8a8edb3
Fix UT
qianheng-aws b161a3b
Fix UT
qianheng-aws c8f2a7f
Address comments
qianheng-aws 3dc6bb2
Merge remote-tracking branch 'refs/remotes/origin/main' into pruneOld
qianheng-aws e8336b5
Fix after merging main
qianheng-aws File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be wrapped in
InterruptibleRelRule?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InterruptibleRelRule is in package
opensearchand has dependency onOpenSearchTimeoutExceptionwhile this rule is packagecore.Therefore, we cannot make this extends
InterruptibleRelRuleunless move that from packageopensearchtocoreand add libraryopensearchin core gradle.On the other hand, if there is interrupt triggered in planning process, it should be detected in our push down rules in package
opensearch.