generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 180
Mvexpand feature #4944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
srikanthpadakanti
wants to merge
65
commits into
opensearch-project:main
Choose a base branch
from
srikanthpadakanti:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mvexpand feature #4944
Changes from 47 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
8362fc2
Initial checkpoint - following calcite way and commented legacy way
384ba15
Removed the build.gradle dependency opensearch-common
7f382f9
Ready to submit this PR
44c8124
Ready to submit this PR
3cad64e
Ready to submit this PR
8e4a2c5
Add mvexpand.rst
474617d
Add Tests
d502b03
Add the mvexpand.rst to the index.rst
c62defe
Remove the unwanted code
a3799b2
Fix the failing test
d90be9f
Address the PR comments and fix the tests accordingly
da16288
Address the PR comments and fix the tests accordingly
1301e06
Address the PR comments and fix the tests accordingly
beb31de
Add comment lines for buildUnnestForLeft
627ef8f
Fix the mvexpand.rst
58facf8
Fix the failing test
63cdbf7
Fix the failing test
bdc3aa1
Fix the failing test
fc8e345
Fix the failing test
c830356
Address the PR comments
e9b6f27
Address the PR comments
fa9436e
Address the PR comments
ea091d2
Address the PR comments
4d9b24d
Address the PR comments
b9d3164
Address the issue as the happy path scenario was not working the way …
26a59a4
MvExpand as its own implementation - not aliasing
43c806e
Refactoring EXPAND and MVEXPAND
a07dff2
Refactor EXPAND and MVEXPAND and fix its unittest
7be7473
Convert mvexpand.rst examples to doctest
2c0ea2c
metadata.rst was missing the mvexpand_logs entry
8749289
Address the PR comments for IT and visitMvExpand
9508874
Merge branch 'main' into main
srikanthpadakanti 08b56ee
Add test for mvdedup function with duplicates
srikanthpadakanti 3ae2c73
Merge branch 'main' into main
srikanthpadakanti bed2084
Update core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVi…
srikanthpadakanti 5e616ff
Update core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVi…
srikanthpadakanti 709704c
Address the PR comments
c45fa05
Address the PR comments
4f3435e
change the limit behavior from global to perDocument
a0b2c8c
Merge branch 'opensearch-project:main' into main
srikanthpadakanti 47779e1
Merge branch 'opensearch-project:main' into main
srikanthpadakanti bf6b924
Fix the CI issues
9aec421
Merge branch 'main' into main
srikanthpadakanti bf87312
Update the index.rst
c9e2767
spotlessapply
2591a6c
Merge branch 'mywork-backup'
125cf3b
spotlessapply
00c990f
address merge issue
44814ab
address merge issue
f9dd692
change rst to md
69d6a5a
Merge branch 'opensearch-project:main' into main
srikanthpadakanti 2464675
change rst to md
0f86c52
delete unnecessary test
32d3867
Merge branch 'main' into main
srikanthpadakanti 07509ae
remove index.rst and add mvexpand entry in index.md
34db739
spotless apply
602358e
merge issues.
b1f2e59
Merge remote-tracking branch 'upstream/main'
2adbf6f
Address and resolve the PR comments from Dec 30th 2025
559165f
Address and resolve the PR comments from Dec 30th 2025
f7d942d
Address and resolve the PR comments from Dec 30th 2025
6ca94e2
Address and resolve the PR comments from Dec 30th 2025
e747edb
Address and resolve the PR comments from Dec 30th 2025
587ccb2
Address and resolve the PR comments from Dec 30th 2025
600637f
Address and resolve the PR comments from Dec 30th 2025
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
core/src/main/java/org/opensearch/sql/ast/tree/MvExpand.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package org.opensearch.sql.ast.tree; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import java.util.List; | ||
| import javax.annotation.Nullable; | ||
| import lombok.EqualsAndHashCode; | ||
| import lombok.Getter; | ||
| import lombok.ToString; | ||
| import org.opensearch.sql.ast.AbstractNodeVisitor; | ||
| import org.opensearch.sql.ast.expression.Field; | ||
|
|
||
| /** AST node representing an {@code mvexpand <field> [limit N]} operation. */ | ||
srikanthpadakanti marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| @ToString | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public class MvExpand extends UnresolvedPlan { | ||
|
|
||
| private UnresolvedPlan child; | ||
| @Getter private final Field field; | ||
| @Getter @Nullable private final Integer limit; | ||
|
|
||
| public MvExpand(Field field, @Nullable Integer limit) { | ||
| this.field = field; | ||
| this.limit = limit; | ||
| } | ||
|
|
||
| @Override | ||
| public MvExpand attach(UnresolvedPlan child) { | ||
| this.child = child; | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public List<UnresolvedPlan> getChild() { | ||
| return this.child == null ? ImmutableList.of() : ImmutableList.of(this.child); | ||
| } | ||
|
|
||
| @Override | ||
| public <T, C> T accept(AbstractNodeVisitor<T, C> nodeVisitor, C context) { | ||
| return nodeVisitor.visitMvExpand(this, context); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.