Skip to content

Add config for CodeRabbit review #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ykmr1224 merged 2 commits into from
Dec 2, 2025
Merged

Add config for CodeRabbit review #4890

ykmr1224 merged 2 commits into from
Dec 2, 2025

Conversation

@ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Dec 1, 2025 •
edited
Loading

Description

Related Issues

#4889
opensearch-project/.github#412

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224
Add review instructions for CodeRabbit
f51d8d8 
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224
Disable auto review
0eebb9c 
Signed-off-by: Tomoyuki Morita <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@ykmr1224 ykmr1224 added maintenance Improves code quality, but not the product infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. and removed maintenance Improves code quality, but not the product labels Dec 2, 2025
@ykmr1224 ykmr1224 marked this pull request as ready for review December 2, 2025 00:38
RyanL1997
RyanL1997 approved these changes Dec 2, 2025
View reviewed changes
Copy link
Collaborator

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ykmr1224, thanks for the change. LGTM. Left a minor question.

.coderabbit.yaml
enabled: false # Disabled auto-review until it becomes stable
auto_incremental_review: false
drafts: false # Don't review draft PRs
ignore_title_keywords:
Copy link
Collaborator

@RyanL1997 RyanL1997 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think we can also start exercising this in our PR template when we initially creating PR.

.rules/REVIEW_GUIDELINES.md
1. **Code Clarity**: Is the code self-explanatory?
2. **Test Coverage**: Are there adequate tests?
3. **Error Handling**: Are errors handled appropriately?
4. **Documentation**: Is JavaDoc complete and accurate?
Copy link
Collaborator

@RyanL1997 RyanL1997 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rule specific for command development?

Copy link
Collaborator Author

@ykmr1224 ykmr1224 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is generic for any code change in this repository.

@ykmr1224 ykmr1224 enabled auto-merge (squash) December 2, 2025 01:07
Swiddis
Swiddis approved these changes Dec 2, 2025
View reviewed changes
.coderabbit.yaml
- Test compatibility with Calcite version constraints

chat:
auto_reply: true
Copy link
Collaborator

@Swiddis Swiddis Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I like this setting, maybe others like it though?

Usually when responding to AI comments the only audience is other reviewers (e.g. "this comment doesn't apply" or "implemented"), I'm not sure I see the value of the AI reply

@ykmr1224 ykmr1224 merged commit 2f6cbfd into opensearch-project:main Dec 2, 2025
44 of 45 checks passed
asifabashar pushed a commit to asifabashar/sql that referenced this pull request Dec 10, 2025
@ykmr1224 @asifabashar
Add config for CodeRabbit review (opensearch-project#4890)
2682804 
* Add review instructions for CodeRabbit

Signed-off-by: Tomoyuki Morita <[email protected]>

* Disable auto review

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Swiddis Swiddis Swiddis approved these changes

@RyanL1997 RyanL1997 RyanL1997 approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar vamsimanohar is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@qianheng-aws qianheng-aws Awaiting requested review from qianheng-aws qianheng-aws is a code owner

@yuancu yuancu Awaiting requested review from yuancu yuancu is a code owner

+1 more reviewer

@ahkcs ahkcs ahkcs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ykmr1224 @Swiddis @ahkcs @RyanL1997