Skip to content

Conversation

@jackiehanyang
Copy link
Contributor

@jackiehanyang jackiehanyang commented Mar 8, 2022

Description

This PR is for PPL integration with AD and ml-commons, and it adds two new commands: KMEANS and AD.

Issues Resolved

N/A

Issues Created

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

❌ Patch coverage is 40.46243% with 103 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.25%. Comparing base (10a9846) to head (c13a368).
⚠️ Report is 1148 commits behind head on main.

Files with missing lines Patch % Lines
...rch/planner/physical/MLCommonsOperatorActions.java 1.75% 56 Missing ⚠️
...ch/sql/opensearch/planner/physical/ADOperator.java 0.00% 27 Missing ⚠️
...opensearch/planner/physical/MLCommonsOperator.java 30.43% 15 Missing and 1 partial ⚠️
...org/opensearch/sql/opensearch/client/MLClient.java 0.00% 3 Missing ⚠️
...a/org/opensearch/sql/utils/MLCommonsConstants.java 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (95.25%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #468       +/-   ##
=============================================
+ Coverage     62.91%   95.25%   +32.33%     
- Complexity        0     2746     +2746     
=============================================
  Files            10      276      +266     
  Lines           658     7414     +6756     
  Branches        118      537      +419     
=============================================
+ Hits            414     7062     +6648     
- Misses          191      298      +107     
- Partials         53       54        +1     
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <40.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penghuo penghuo merged commit eb1ede4 into opensearch-project:main Mar 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 9, 2022
Signed-off-by: jackieyanghan <[email protected]>
(cherry picked from commit eb1ede4)
penghuo pushed a commit that referenced this pull request Mar 9, 2022
Signed-off-by: jackieyanghan <[email protected]>
(cherry picked from commit eb1ede4)

Co-authored-by: Jackie Han <[email protected]>
@penghuo penghuo added the PPL Piped processing language label Mar 9, 2022
@joshuali925 joshuali925 mentioned this pull request Mar 11, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.x PPL Piped processing language v1.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants