[Backport 2.19-dev] Pushdown case function in aggregations as range queries (#4400) #4630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuancu
force-pushed
the
backport/backport-4400-to-2.19-dev
branch
2 times, most recently
from
4db1fe1 to
6e9fd4f
Compare
…roject#4400) * WIP: implementing case range analyzer Signed-off-by: Yuanchun Shen <[email protected]> * Correct case analyzer Signed-off-by: Yuanchun Shen <[email protected]> * Create bucket aggregation parsers that supports parsing nested sub aggregations Signed-off-by: Yuanchun Shen <[email protected]> * Fix unit tests Signed-off-by: Yuanchun Shen <[email protected]> * Fix parsers to multi-range cases Signed-off-by: Yuanchun Shen <[email protected]> * Update leaf bucket parser Signed-off-by: Yuanchun Shen <[email protected]> * Unit test case range analyzer Signed-off-by: Yuanchun Shen <[email protected]> * Add explain ITs for pushing down case in aggregations Signed-off-by: Yuanchun Shen <[email protected]> * Update CaseRangeAnalyzerTest Signed-off-by: Yuanchun Shen <[email protected]> * Add a yaml test that replicates issue 4201 Signed-off-by: Yuanchun Shen <[email protected]> * Add integration tests for case in aggregation Signed-off-by: Yuanchun Shen <[email protected]> * Fix unit tests Signed-off-by: Yuanchun Shen <[email protected]> * Add a patch to CalcitePPLCaseFunctionIT Signed-off-by: Yuanchun Shen <[email protected]> * Migrate all composite aggregation parser usage to bucket aggregate parser Signed-off-by: Yuanchun Shen <[email protected]> * Create a parent abstract classes for BucketAggregationParsers Signed-off-by: Yuanchun Shen <[email protected]> * Remove an unnecessary bucket agg in AggregationQueryBuilder Signed-off-by: Yuanchun Shen <[email protected]> * Test pushing down case where there exists null values Signed-off-by: Yuanchun Shen <[email protected]> * Return empty in CaseRangeAnalyzer to unblock the rest pushdown - Additionally test number as result expressions Signed-off-by: Yuanchun Shen <[email protected]> * Document limitations of pushding case as range queries Signed-off-by: Yuanchun Shen <[email protected]> * Make case pushdown a private method Signed-off-by: Yuanchun Shen <[email protected]> * Chores: remove unused helper method Signed-off-by: Yuanchun Shen <[email protected]> * Unify logics for creating nested aggregations Signed-off-by: Yuanchun Shen <[email protected]> * Remove a note in condition.rst Signed-off-by: Yuanchun Shen <[email protected]> * Optmize range aggregation Signed-off-by: Yuanchun Shen <[email protected]> * Ignore testNestedAggregationsExplain when pushdown is disabled Signed-off-by: Yuanchun Shen <[email protected]> * Fix explain ITs after merge Signed-off-by: Yuanchun Shen <[email protected]> --------- Signed-off-by: Yuanchun Shen <[email protected]> (cherry picked from commit 18ab4dc) # Conflicts: # integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
Signed-off-by: Yuanchun Shen <[email protected]>
yuancu
force-pushed
the
backport/backport-4400-to-2.19-dev
branch
from
6e9fd4f to
79e2326
Compare
Signed-off-by: Yuanchun Shen <[email protected]>
yuancu
force-pushed
the
backport/backport-4400-to-2.19-dev
branch
from
3ef75e1 to
aaa4adf
Compare
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
LantaoJin
approved these changes
Oct 24, 2025
qianheng-aws
approved these changes
Oct 24, 2025
qianheng-aws
merged commit b116dd6
into
opensearch-project:2.19-dev
69 of 70 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #4400 to 2.19-dev
Commit Message
WIP: implementing case range analyzer
Correct case analyzer
Create bucket aggregation parsers that supports parsing nested sub aggregations
Fix unit tests
Fix parsers to multi-range cases
Update leaf bucket parser
Unit test case range analyzer
Add explain ITs for pushing down case in aggregations
Update CaseRangeAnalyzerTest
Add a yaml test that replicates issue 4201
Add integration tests for case in aggregation
Fix unit tests
Add a patch to CalcitePPLCaseFunctionIT
Migrate all composite aggregation parser usage to bucket aggregate parser
Create a parent abstract classes for BucketAggregationParsers
Remove an unnecessary bucket agg in AggregationQueryBuilder
Test pushing down case where there exists null values
Return empty in CaseRangeAnalyzer to unblock the rest pushdown
Document limitations of pushding case as range queries
Make case pushdown a private method
Chores: remove unused helper method
Unify logics for creating nested aggregations
Remove a note in condition.rst
Optmize range aggregation
Ignore testNestedAggregationsExplain when pushdown is disabled
Fix explain ITs after merge
(cherry picked from commit 18ab4dc)
Related Issues
Resolves #4201
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.