Skip to content

Treating ExpressionEvaluationException as client Error. #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vamsimanohar merged 1 commit into from
Mar 4, 2022
Merged

Treating ExpressionEvaluationException as client Error. #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion legacy/src/main/java/org/opensearch/sql/legacy/plugin/RestSqlAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.opensearch.rest.RestRequest;
import org.opensearch.rest.RestStatus;
import org.opensearch.sql.common.antlr.SyntaxCheckException;
import org.opensearch.sql.exception.ExpressionEvaluationException;
import org.opensearch.sql.exception.SemanticCheckException;
import org.opensearch.sql.legacy.antlr.OpenSearchLegacySqlAnalyzer;
import org.opensearch.sql.legacy.antlr.SqlAnalysisConfig;
Expand Down Expand Up @@ -244,7 +245,8 @@ private static boolean isClientError(Exception e) {
|| e instanceof VerificationException
|| e instanceof SqlAnalysisException
|| e instanceof SyntaxCheckException
|| e instanceof SemanticCheckException;
|| e instanceof SemanticCheckException
|| e instanceof ExpressionEvaluationException;
}

private void sendResponse(final RestChannel channel, final String message, final RestStatus status) {
Expand Down