Skip to content

Fix percentile bug #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qianheng-aws merged 3 commits into from
Oct 14, 2025
Merged

Fix percentile bug #4539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b26eb24
fix percentile bug
xinyual Oct 14, 2025
17f4ac0
add IT
xinyual Oct 14, 2025
4ac2b46
optimize it
xinyual Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/opensearch/sql/calcite/udf/udaf/PercentileApproxFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public Object result(PencentileApproAccumulator acc) {
float floatRet = (float) retValue;
return floatRet;
default:
return acc.value();
return retValue;
}
}

Expand Down
20 changes: 20 additions & 0 deletions integ-test/src/test/java/org/opensearch/sql/ppl/StatsCommandIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,26 @@ public void testStatsPercentile() throws IOException {
verifyDataRows(response, rows(32838));
}

@Test
public void testStatsPercentileWithMin() throws IOException {
JSONObject response =
executeQuery(
String.format(
"source=%s | eval decimal=ceil(balance/100000.0) | stats percentile(decimal, 50),"
+ " min(decimal)",
TEST_INDEX_BANK));
String returnType = "bigint";
if (isCalciteEnabled()) {
returnType = "double";
}

verifySchema(
response,
schema("percentile(decimal, 50)", null, returnType),
schema("min(decimal)", null, returnType));
verifyDataRows(response, rows(1, 1));
}

@Test
public void testStatsPercentileWithNull() throws IOException {
JSONObject response =
Expand Down
Loading