Support eval returns decimal division result instead of integer #4440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
penghuo
changed the title
penghuo
commented
Oct 6, 2025
| } | ||
| } | ||
|
|
||
| Example 2 |
penghuo
commented
Oct 6, 2025
| } | ||
| } | ||
| } | ||
| CalcitePlanContext.run( |
Collaborator
Author
There was a problem hiding this comment.
Wrap with CalcitePlanContext.run, No code logic change.
penghuo
commented
Oct 6, 2025
| } | ||
| } | ||
| } | ||
| CalcitePlanContext.run( |
Collaborator
Author
There was a problem hiding this comment.
Wrap with CalcitePlanContext.run, No code logic change.
Signed-off-by: Peng Huo <[email protected]>
penghuo
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
ps48,
seankao-az,
vamsimanohar and
ykmr1224
as code owners
penghuo
requested review from
LantaoJin,
RyanL1997,
noCharger,
qianheng-aws and
yuancu
as code owners
Collaborator
Author
|
@yuancu @LantaoJin Please take a look. |
yuancu
approved these changes
Oct 9, 2025
Collaborator
yuancu
left a comment
yuancu
left a comment
There was a problem hiding this comment.
Thanks for the change! With this change, I think the old implementation DivideFunction can be removed.
dai-chen
approved these changes
Oct 10, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
--------- Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit b170cf1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo
pushed a commit
that referenced
this pull request
Oct 11, 2025
… (#4509) --------- (cherry picked from commit b170cf1) Signed-off-by: Peng Huo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#3946
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.