Skip to content

Conversation

@aalva500-prog
Copy link
Contributor

Description

Currently, SQL/PPL Count Query Is Maxed at MAX_INT

For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:

{
"query": ""source = accounts | stats count(requestId)""
}
{
  "schema": [
    {
      "name": "count(requestId)",
      "type": "integer"
    }
  ],
  "datarows": [
    [
      2147483647
    ]
  ],
  "total": 1,
  "size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:

{
"query": ""source = accounts | stats count(requestId)""
}
{
  "schema": [
    {
      "name": "count(requestId)",
      "type": "bigint"
    }
  ],
  "datarows": [
    [
      2147483647
    ]
  ],
  "total": 1,
  "size": 1
}

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

RyanL1997 pushed a commit that referenced this pull request Oct 1, 2025
asifabashar added a commit to asifabashar/sql that referenced this pull request Oct 10, 2025
* main-apple: (218 commits)
  Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
  Create fab-radar.yml
  PPL `fillnull` command enhancement (opensearch-project#4421)
  reverting to _doc + _id (opensearch-project#4435)
  Support `multisearch` command in calcite (opensearch-project#4332)
  Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
  [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
  Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
  [Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
  Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
  Version bump: 3.3 (opensearch-project#4417)
  Add max/min eval functions (opensearch-project#4333)
  Support time modifiers in search command  (opensearch-project#4224)
  Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
  refactor span (opensearch-project#4334)
  Move release notes categories (opensearch-project#3818)
  [Doc] Enable doctest with Calcite (opensearch-project#4379)
  Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
  Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
  Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
  ...
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2025
…GER #4416 (#4418)

Co-authored-by: Aaron Alvarez <[email protected]>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit that referenced this pull request Oct 28, 2025
…e capped at MAX_INTEGER #4416 (#4656)

* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)

Co-authored-by: Aaron Alvarez <[email protected]>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix IT

Signed-off-by: Lantao Jin <[email protected]>

* Fix IT

Signed-off-by: Lantao Jin <[email protected]>

---------

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <[email protected]>
Co-authored-by: Lantao Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants