[Backport 2.19-dev] Fix numbered token bug and make it optional output in patterns command (#4402) #4414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-project#4402) * Fix patterns command incorrectly parsing token and add parameter option Signed-off-by: Songkan Tang <[email protected]> * Fix some cases after merge Signed-off-by: Songkan Tang <[email protected]> * Fix failed tests Signed-off-by: Songkan Tang <[email protected]> * Fix UTs and modify docs Signed-off-by: Songkan Tang <[email protected]> * Add Brain parameter explanation to the doc Signed-off-by: Songkan Tang <[email protected]> * Modify patterns doctest after calcite default engine enabled Signed-off-by: Songkan Tang <[email protected]> * Rephrase some words in patterns.rst Signed-off-by: Songkan Tang <[email protected]> --------- Signed-off-by: Songkan Tang <[email protected]>
songkant-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
LantaoJin
approved these changes
Sep 30, 2025
penghuo
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix patterns command incorrectly parsing token and add parameter option
Fix some cases after merge
Fix failed tests
Fix UTs and modify docs
Add Brain parameter explanation to the doc
Modify patterns doctest after calcite default engine enabled
Rephrase some words in patterns.rst
Description
Backport #4402
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.