-
Notifications
You must be signed in to change notification settings - Fork 180
Update bin.rst and add bin to doctest
#4384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kai Huang <[email protected]>
Signed-off-by: Kai Huang <[email protected]>
docs/user/ppl/cmd/bin.rst
Outdated
| | 30-40 | | ||
| | 35-45 | | ||
| | 25-35 | | ||
| | 30-40 | | ||
| | 20-30 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical, but these examples might be a bit confusing since it shows duplicate age bins. It is better showing other field to indicate age is just showing the bin for each record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated some tests to use fields command
doctest/test_docs.py
Outdated
| 'otellogs': 'otellogs.json', | ||
| 'time_test': 'time_test.json', | ||
| 'bank': 'bank.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reuse existing ones if possible. I think bank can be replaced with accounts, at least. Not sure if we have json with timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 lets reuse unless necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't have json with timestamp so I kept time_test.json, removed bank.json
docs/category.json
Outdated
| "user/ppl/cmd/rex.rst", | ||
| "user/ppl/cmd/stats.rst", | ||
| "user/ppl/cmd/timechart.rst", | ||
| "user/ppl/cmd/bin.rst", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put items in alphabetical order to easily identify duplicate record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Signed-off-by: Kai Huang <[email protected]>
Signed-off-by: Kai Huang <[email protected]>
|
#4379 is to moving all doctest to calcite. But I can rebase that one. Let's merge this first. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4384-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 877e6d586287171019b4390231accd7f2a887c2a
# Push it to GitHub
git push --set-upstream origin backport/backport-4384-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
Signed-off-by: Kai Huang <[email protected]> (cherry picked from commit 877e6d5)
Description
Update the doctest for bin.rst file
Removed floating point for numeric span