Skip to content

Conversation

@ahkcs
Copy link
Contributor

@ahkcs ahkcs commented Sep 25, 2025

Description

Update the doctest for bin.rst file
Removed floating point for numeric span

Signed-off-by: Kai Huang <[email protected]>
@ahkcs ahkcs marked this pull request as ready for review September 25, 2025 23:04
@ahkcs ahkcs changed the title Update bin doctest Update bin.rst and add bin to doctest Sep 25, 2025
@vamsimanohar vamsimanohar added maintenance Improves code quality, but not the product backport 2.19-dev labels Sep 25, 2025
Signed-off-by: Kai Huang <[email protected]>
Comment on lines 248 to 250
| 30-40 |
| 35-45 |
| 25-35 |
| 30-40 |
| 20-30 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical, but these examples might be a bit confusing since it shows duplicate age bins. It is better showing other field to indicate age is just showing the bin for each record.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated some tests to use fields command

Comment on lines 44 to 46
'otellogs': 'otellogs.json',
'time_test': 'time_test.json',
'bank': 'bank.json'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reuse existing ones if possible. I think bank can be replaced with accounts, at least. Not sure if we have json with timestamp.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lets reuse unless necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't have json with timestamp so I kept time_test.json, removed bank.json

"user/ppl/cmd/rex.rst",
"user/ppl/cmd/stats.rst",
"user/ppl/cmd/timechart.rst",
"user/ppl/cmd/bin.rst",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put items in alphabetical order to easily identify duplicate record.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Signed-off-by: Kai Huang <[email protected]>
@ahkcs ahkcs requested a review from ykmr1224 September 26, 2025 00:17
Signed-off-by: Kai Huang <[email protected]>
@LantaoJin
Copy link
Member

#4379 is to moving all doctest to calcite. But I can rebase that one. Let's merge this first.

@LantaoJin LantaoJin added documentation Improvements or additions to documentation and removed maintenance Improves code quality, but not the product labels Sep 26, 2025
@qianheng-aws qianheng-aws merged commit 877e6d5 into opensearch-project:main Sep 26, 2025
36 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19-dev failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4384-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 877e6d586287171019b4390231accd7f2a887c2a
# Push it to GitHub
git push --set-upstream origin backport/backport-4384-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev

Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4384-to-2.19-dev.

ahkcs added a commit to ahkcs/sql that referenced this pull request Sep 26, 2025
Signed-off-by: Kai Huang <[email protected]>
(cherry picked from commit 877e6d5)
@LantaoJin LantaoJin added the backport-manually Filed a PR to backport manually. label Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.19-dev backport-failed backport-manually Filed a PR to backport manually. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants