Prevent limit pushdown before action building instead of in action executing #4377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f waiting until action is executed Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
changed the title
8 tasks
Member
Author
|
This blocks CI workflow in #4372 |
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
yuancu
approved these changes
Sep 25, 2025
penghuo
approved these changes
Sep 26, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…ecuting (#4377) * The limit pushdown check logic should be in action building instead of waiting until action is executed Signed-off-by: Lantao Jin <[email protected]> * Add an explain IT Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 18f2280) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
qianheng-aws
pushed a commit
that referenced
this pull request
Sep 26, 2025
…tead of in action executing (#4386) * Prevent limit pushdown before action building instead of in action executing (#4377) * The limit pushdown check logic should be in action building instead of waiting until action is executed Signed-off-by: Lantao Jin <[email protected]> * Add an explain IT Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 18f2280) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix compiler error Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lantao Jin <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3713 tried to prevent push down limit with offset reach maxResultWindow in action being executing (applying) which didn't work in v3.
Fixing: Prevent limit pushdown before action building instead of in action executing
Related Issues
Resolves #4376
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.