Skip to content

Spotless precommit: apply instead of check #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Swiddis merged 12 commits into from
Sep 17, 2025
Merged

Spotless precommit: apply instead of check #4320

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
66ff7c1
Add spotless precommit hook
Swiddis Sep 16, 2025
3180591
Decouple plugin spotless versions + upgrade spotless
Swiddis Sep 16, 2025
09b5da0
Enable license headers everywhere
Swiddis Sep 16, 2025
e2cf5fe
Remove a redundant comment
Swiddis Sep 16, 2025
9fb81dd
Fix removed additional licenses
Swiddis Sep 16, 2025
f3272b5
Apply spotless before check in precommit
Swiddis Sep 17, 2025
3bb1d0a
Just apply, skip check
Swiddis Sep 17, 2025
59051a0
Merge remote-tracking branch 'upstream/main' into hotfix/spotless-lic…
Swiddis Sep 17, 2025
513d2ce
Simplify (precommit is good at staging, it turns out)
Swiddis Sep 17, 2025
8118f26
Fix metadata doctest
Swiddis Sep 17, 2025
3c25a92
Revert "Fix metadata doctest"
Swiddis Sep 17, 2025
e70ae8a
Check after apply
Swiddis Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
repos:
- repo: local
hooks:
- id: spotless-format
name: Spotless Format
entry: bash -c './gradlew spotlessApply && git add -u'
language: system
pass_filenames: false
- id: spotless-check
name: Spotless Check
entry: ./gradlew spotlessCheck
name: Spotless Post-format Check
entry: bash -c './gradlew spotlessCheck'
language: system
pass_filenames: false
Loading