Skip to content

Conversation

@ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Sep 3, 2025

backport e2a1132 from #4100

(manual backport due to minor conflicts)

@ykmr1224
Copy link
Collaborator Author

ykmr1224 commented Sep 3, 2025

doctest is failing due to regex.rst not found.
It is because #4218 haven't merged. I will rebase after it is merged.

> Task :doctest:doctest FAILED
======================================================================
ERROR: test_docs (unittest.loader._FailedTest.test_docs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/sql/sql/doctest/test_docs.py", line 343, in load_tests
    tests.append(get_test_suite(category_manager, category_name, get_doc_filepaths(docs)))
                 ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/sql/sql/doctest/test_docs.py", line 355, in get_test_suite
    return create_cli_suite(filepaths, parser, setup_func)
  File "/Users/runner/work/sql/sql/doctest/test_docs.py", line 327, in create_cli_suite
    return docsuite(
        *filepaths,
        parser=parser,
        setUp=setup_func
    )
  File "/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/doctest.py", line 2633, in DocFileSuite
    suite.addTest(DocFileTest(path, **kw))
                  ~~~~~~~~~~~^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/doctest.py", line 2555, in DocFileTest
    doc, path = _load_testfile(path, package, module_relative,
                ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                               encoding or "utf-8")
                               ^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/doctest.py", line 253, in _load_testfile
    file_contents = loader.get_data(filename)
  File "<frozen importlib._bootstrap_external>", line 1217, in get_data
FileNotFoundError: [Errno 2] No such file or directory: '/Users/runner/work/sql/sql/doctest/../docs/user/ppl/cmd/regex.rst'

)

* Add earliest/latest aggregate function to PPL

Signed-off-by: Tomoyuki Morita <[email protected]>

* Reformat

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add IT

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix integ test

Signed-off-by: Tomoyuki Morita <[email protected]>

* Use ARG_MAX and ARG_MIN instead

Signed-off-by: Tomoyuki Morita <[email protected]>

* Revert comment deletion

Signed-off-by: Tomoyuki Morita <[email protected]>

* Remove min_by and max_by

Signed-off-by: Tomoyuki Morita <[email protected]>

* Update doc

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix tests

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix tests

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix tests

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fit IT

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix doctest

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix doctest

Signed-off-by: Tomoyuki Morita <[email protected]>

* Remove unneeded test

Signed-off-by: Tomoyuki Morita <[email protected]>

* Delete unneeded files

Signed-off-by: Tomoyuki Morita <[email protected]>

* Minor fix

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix issue caused by conflict

Signed-off-by: Tomoyuki Morita <[email protected]>

* reformat

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix doctest issue

Signed-off-by: Tomoyuki Morita <[email protected]>

* Minor fix

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix tests

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix test_docs

Signed-off-by: Tomoyuki Morita <[email protected]>

* Update test_docs.py

Signed-off-by: Tomoyuki Morita <[email protected]>

* Refactor test_docs.py and fix

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix issues caused by merge

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki MORITA <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224 ykmr1224 force-pushed the backport/backport-4100-to-2.19-dev branch from d0b3954 to 11b07e1 Compare September 3, 2025 23:01
@ykmr1224
Copy link
Collaborator Author

ykmr1224 commented Sep 3, 2025

Rebased.

@penghuo penghuo merged commit be664e0 into opensearch-project:2.19-dev Sep 4, 2025
24 checks passed
@ykmr1224 ykmr1224 deleted the backport/backport-4100-to-2.19-dev branch September 4, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants