Skip to content

Bin command big5 queries #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Swiddis merged 5 commits into from
Sep 5, 2025
Merged

Bin command big5 queries #4163

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b25b3f
Bin command big5 queries
ahkcs Aug 28, 2025
559a928
update IT
ahkcs Aug 29, 2025
b94cc31
fix
ahkcs Aug 29, 2025
000a3fe
Merge branch 'main' into big5_q
ahkcs Sep 3, 2025
91e2857
remove tests
ahkcs Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions integ-test/src/test/java/org/opensearch/sql/calcite/big5/CalcitePPLBig5IT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@

package org.opensearch.sql.calcite.big5;

import java.io.IOException;
import org.junit.FixMethodOrder;
import org.junit.Test;
import org.junit.runners.MethodSorters;

@FixMethodOrder(MethodSorters.JVM)
Expand All @@ -16,4 +18,52 @@ public void init() throws Exception {
super.init();
enableCalcite();
}

@Test
public void bin_aligntime() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_aligntime.ppl"));
Copy link
Collaborator

@ykmr1224 ykmr1224 Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Why do we need to load from separate file? Query seems simple and it should be simpler to write here.

Copy link
Contributor Author

@ahkcs ahkcs Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are adding this IT to verify if the queries we put under the big5 queries folder works, also to be consistent with merged PR: #4127

Copy link
Collaborator

@Swiddis Swiddis Sep 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ keeping it separate helps us copy the queries as benchmark cases, we want to ideally just copy the contents of big5/queries and generate workloads from it.

timing(summary, "bin_aligntime", ppl);
}

@Test
public void bin_bins() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_bins.ppl"));
timing(summary, "bin_bins", ppl);
}

@Test
public void bin_default() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_default.ppl"));
timing(summary, "bin_default", ppl);
}

@Test
public void bin_minspan() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_minspan.ppl"));
timing(summary, "bin_minspan", ppl);
}

@Test
public void bin_span_log() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_span_log.ppl"));
timing(summary, "bin_span_log", ppl);
}

@Test
public void bin_span_numeric() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_span_numeric.ppl"));
timing(summary, "bin_span_numeric", ppl);
}

@Test
public void bin_span_time() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_span_time.ppl"));
timing(summary, "bin_span_time", ppl);
}

@Test
public void bin_start_end() throws IOException {
String ppl = sanitize(loadFromFile("big5/queries/bin_start_end.ppl"));
timing(summary, "bin_start_end", ppl);
}
}
2 changes: 1 addition & 1 deletion integ-test/src/test/java/org/opensearch/sql/calcite/big5/PPLBig5IT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

@FixMethodOrder(MethodSorters.JVM)
public class PPLBig5IT extends PPLIntegTestCase {
private static final MapBuilder<String, Long> summary = MapBuilder.newMapBuilder();
protected static final MapBuilder<String, Long> summary = MapBuilder.newMapBuilder();

@Override
public void init() throws Exception {
Expand Down
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_aligntime.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `@timestamp` span=12h aligntime=\"@d+3h\"
| head 10
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_bins.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `metrics.size` bins=5
| head 10
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_default.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `metrics.size`
| head 10
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_minspan.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `metrics.size` minspan=100
| head 10
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_span_log.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `metrics.size` span=log10
| head 10
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_span_numeric.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `metrics.size` span=1000
| head 10
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_span_time.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `@timestamp` span=1h
| head 10
3 changes: 3 additions & 0 deletions integ-test/src/test/resources/big5/queries/bin_start_end.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source = big5
| bin `metrics.size` bins=5 start=0 end=10000
| head 10
Loading