[Backport 2.19-dev] Push down IP comparison as range query with Calcite (#3959) #4080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#3959) * Add reverse op for compare ip to support pushdown Signed-off-by: Yuanchun Shen <[email protected]> * Pushdown ip comparison Signed-off-by: Yuanchun Shen <[email protected]> * Refactor CompareIpFunction to use SqlKind directly Signed-off-by: Yuanchun Shen <[email protected]> * Simplify the overriding of reverse() for IP comparators Signed-off-by: Yuanchun Shen <[email protected]> --------- Signed-off-by: Yuanchun Shen <[email protected]> (cherry picked from commit e2375fe)
yuancu
force-pushed
the
backport/backport-3959-to-2.19-dev
branch
from
87e335f to
c2011ea
Compare
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
LantaoJin
approved these changes
Aug 20, 2025
qianheng-aws
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #3959 to 2.19-dev
Commit Message
Add reverse op for compare ip to support pushdown
Pushdown ip comparison
Refactor CompareIpFunction to use SqlKind directly
Simplify the overriding of reverse() for IP comparators
(cherry picked from commit e2375fe)
Related Issues
Resolves #3937
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.