Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 9f2b19a from #4001.

* Remove named function arg from functions other than table functions

Signed-off-by: Yuanchun Shen <[email protected]>

* Test eval if function with equal as condition

Signed-off-by: Yuanchun Shen <[email protected]>

---------

Signed-off-by: Yuanchun Shen <[email protected]>
(cherry picked from commit 9f2b19a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@yuancu
Copy link
Collaborator

yuancu commented Aug 19, 2025

There's a failed test:

org.opensearch.sql.calcite.tpch.CalcitePPLTpchIT > testQ7 FAILED
    java.net.SocketTimeoutException: 60 000 milliseconds timeout on connection http-outgoing-469 [ACTIVE]
        at __randomizedtesting.SeedInfo.seed([533FB44206321030:8473C8A764182F94]:0)
        at org.opensearch.client.RestClient.extractAndWrapCause(RestClient.java:1230)
        at org.opensearch.client.RestClient.performRequest(RestClient.java:358)
        at org.opensearch.client.RestClient.performRequest(RestClient.java:361)
        at org.opensearch.client.RestClient.performRequest(RestClient.java:346)
        at org.opensearch.sql.ppl.PPLIntegTestCase.executeQueryToString(PPLIntegTestCase.java:48)
        at org.opensearch.sql.ppl.PPLIntegTestCase.executeQuery(PPLIntegTestCase.java:44)
        at org.opensearch.sql.calcite.tpch.CalcitePPLTpchIT.testQ7(CalcitePPLTpchIT.java:178)

        Caused by:
        java.net.SocketTimeoutException: 60 000 milliseconds timeout on connection http-outgoing-469 [ACTIVE]
            at org.apache.http.nio.protocol.HttpAsyncRequestExecutor.timeout(HttpAsyncRequestExecutor.java:387)
            at org.apache.http.impl.nio.client.InternalIODispatch.onTimeout(InternalIODispatch.java:98)
            at org.apache.http.impl.nio.client.InternalIODispatch.onTimeout(InternalIODispatch.java:40)
            at org.apache.http.impl.nio.reactor.AbstractIODispatch.timeout(AbstractIODispatch.java:175)
            at org.apache.http.impl.nio.reactor.BaseIOReactor.sessionTimedOut(BaseIOReactor.java:261)
            at org.apache.http.impl.nio.reactor.AbstractIOReactor.timeoutCheck(AbstractIOReactor.java:506)
            at org.apache.http.impl.nio.reactor.BaseIOReactor.validate(BaseIOReactor.java:211)
            at org.apache.http.impl.nio.reactor.AbstractIOReactor.execute(AbstractIOReactor.java:280)
            at org.apache.http.impl.nio.reactor.BaseIOReactor.execute(BaseIOReactor.java:104)
            at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor$Worker.run(AbstractMultiworkerIOReactor.java:591)
            at java.base/java.lang.Thread.run(Thread.java:829)

Can this be safely viewed as flaky? @LantaoJin

Copy link
Member

@LantaoJin LantaoJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The flaky will be fixed in my other PR

@qianheng-aws qianheng-aws merged commit fe2e83c into 2.19-dev Aug 20, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants