[Backport 2.19-dev] Implement type checking for aggregation functions with Calcite (#4024) #4054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-project#4024) * Remove getTypeChecker from FunctionImp interface Signed-off-by: Yuanchun Shen <[email protected]> * Refactor registerExternalFunction to registerExternalOperator Signed-off-by: Yuanchun Shen <[email protected]> * Do not register GEOIP function if got incompatible client Signed-off-by: Yuanchun Shen <[email protected]> * Create scaffold for type checking of aggregation functions Signed-off-by: Yuanchun Shen <[email protected]> * Add type checkers for aggregation functions Signed-off-by: Yuanchun Shen <[email protected]> * Test type checking for aggregation functions Signed-off-by: Yuanchun Shen <[email protected]> --------- Signed-off-by: Yuanchun Shen <[email protected]> (cherry picked from commit d758163)
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
LantaoJin
approved these changes
Aug 18, 2025
penghuo
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #4024 to 2.19-dev
Commit Message
Remove getTypeChecker from FunctionImp interface
Refactor registerExternalFunction to registerExternalOperator
Do not register GEOIP function if got incompatible client
Create scaffold for type checking of aggregation functions
Add type checkers for aggregation functions
Test type checking for aggregation functions
(cherry picked from commit d758163)
Related Issues
Resolves #4000
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.