adding capability in SQLQueryUtils to identify if SQL query is for creating a table or not. #4029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayank Aggarwal <[email protected]>
aggarwalmayank
changed the title
aggarwalmayank
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Signed-off-by: Mayank Aggarwal <[email protected]>
ykmr1224
reviewed
Aug 19, 2025
| statement.accept(visitor); | ||
|
|
||
| // Remove duplicate table names | ||
| List<FullyQualifiedTableName> uniqueFullyQualifiedTableName = new LinkedList<>(); |
Collaborator
There was a problem hiding this comment.
nit: let's put s at the end of the variable name (since it is a list)
| new SqlBaseParser( | ||
| new CommonTokenStream(new SqlBaseLexer(new CaseInsensitiveCharStream(sqlQuery)))); | ||
| sqlBaseParser.addErrorListener(new SyntaxAnalysisErrorListener()); | ||
| return extractFullyQualifiedTableNamesWithMetadata(sqlQuery).getFullyQualifiedTableNames(); |
Collaborator
There was a problem hiding this comment.
Would it actually avoid parsing query twice?
Contributor
Author
There was a problem hiding this comment.
yes, users can use any of the method as per their requirement and the same visitor "SparkSqlTableNameVisitor" can be used
Signed-off-by: Mayank Aggarwal <[email protected]>
ykmr1224
approved these changes
Aug 20, 2025
penghuo
approved these changes
Aug 20, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2025
…eating a table or not. (#4029) * adding capability to identify if SQL query is create table or not Signed-off-by: Mayank Aggarwal <[email protected]> * fixing codestyle violations Signed-off-by: Mayank Aggarwal <[email protected]> * updating variable name Signed-off-by: Mayank Aggarwal <[email protected]> --------- Signed-off-by: Mayank Aggarwal <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]> (cherry picked from commit 5cb5181) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-4029-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5cb51814ed1bb527c47a5e827c773a1899c081e9
# Push it to GitHub
git push --set-upstream origin backport/backport-4029-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
Collaborator
|
Need manual backport. |
Parasjg
pushed a commit
to Parasjg/sql
that referenced
this pull request
Dec 24, 2025
…eating a table or not. (opensearch-project#4029) * adding capability to identify if SQL query is create table or not Signed-off-by: Mayank Aggarwal <[email protected]> * fixing codestyle violations Signed-off-by: Mayank Aggarwal <[email protected]> * updating variable name Signed-off-by: Mayank Aggarwal <[email protected]> --------- Signed-off-by: Mayank Aggarwal <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]>
2 tasks
Parasjg
pushed a commit
to Parasjg/sql
that referenced
this pull request
Dec 30, 2025
…eating a table or not. (opensearch-project#4029) * adding capability to identify if SQL query is create table or not Signed-off-by: Mayank Aggarwal <[email protected]> * fixing codestyle violations Signed-off-by: Mayank Aggarwal <[email protected]> * updating variable name Signed-off-by: Mayank Aggarwal <[email protected]> --------- Signed-off-by: Mayank Aggarwal <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]> Signed-off-by: Paras jaggi <[email protected]>
2 tasks
LantaoJin
pushed a commit
that referenced
this pull request
Jan 7, 2026
…eating a table or not. (#4029) (#5007) * adding capability to identify if SQL query is create table or not * fixing codestyle violations * updating variable name --------- Signed-off-by: Mayank Aggarwal <[email protected]> Signed-off-by: Paras jaggi <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
adding capability in SQLQueryUtils to identify if SQL query is for creating a table or not.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
NA
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.