Make fields optional parameter in multi field relevance function. #4018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsimanohar
force-pushed
the
search_text
branch
from
9059c5a to
6bf78fa
Compare
vamsimanohar
changed the title
vamsimanohar
force-pushed
the
search_text
branch
2 times, most recently
from
98c52fa to
64b982b
Compare
vamsimanohar
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Swiddis
requested changes
Aug 12, 2025
Collaborator
Swiddis
left a comment
Swiddis
left a comment
There was a problem hiding this comment.
Please add some docs (comments or otherwise) to explain how this works. I'm able to follow individual methods and I think I see an entrypoint, but I don't see how everything is linking together.
core/src/main/java/org/opensearch/sql/expression/function/udf/RelevanceQueryFunction.java
Show resolved
Hide resolved
...va/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/MultiFieldQuery.java
Show resolved
Hide resolved
...opensearch/sql/opensearch/storage/script/filter/lucene/relevance/SimpleQueryStringQuery.java
Show resolved
Hide resolved
ppl/src/main/java/org/opensearch/sql/ppl/parser/AstExpressionBuilder.java
Show resolved
Hide resolved
vamsimanohar
force-pushed
the
search_text
branch
from
64b982b to
9f80dbb
Compare
penghuo
reviewed
Aug 18, 2025
core/src/main/java/org/opensearch/sql/calcite/CalciteRexNodeVisitor.java
Outdated
Show resolved
Hide resolved
penghuo
previously approved these changes
Aug 19, 2025
Collaborator
penghuo
left a comment
penghuo
left a comment
There was a problem hiding this comment.
@songkant-aws Please take a look.
ppl/src/main/java/org/opensearch/sql/ppl/parser/AstExpressionBuilder.java
Show resolved
Hide resolved
vamsimanohar
force-pushed
the
search_text
branch
3 times, most recently
from
08795e3 to
eef1df5
Compare
Member
Author
|
The integ test failure is unrelated to this PR |
Signed-off-by: Vamsi Manohar <[email protected]>
vamsimanohar
force-pushed
the
search_text
branch
from
eef1df5 to
6fd92bc
Compare
penghuo
approved these changes
Aug 20, 2025
Swiddis
approved these changes
Aug 20, 2025
songkant-aws
approved these changes
Aug 21, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2025
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 5c0ed0d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar
added a commit
that referenced
this pull request
Aug 21, 2025
…evance function. (#4093) * Make fields parameter optional in multi field relevance queries (#4018) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 5c0ed0d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fixed text block syntax issue for Java 11 Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vamsi Manohar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first step in making it easier to search in PPL. We want to support a simple "free text search" like the one described in this issue
The goal is to let you write a simple search like this:
search source = my_index "fatal error"And our system will automatically translate it to this behind the scenes:
search source = my_index | where simple_query_string("fatal error")Changes in this PR
To prepare for the new free text search, I'm updating how a few of our search functions work.
Now, you won't always have to provide a list of fields to search in. The
fieldsparameter is now optional for functions likesimple_query_stringandmulti_match.If you don't specify any fields, the query will automatically search the default fields set up for that index (specifically, in the
index.query.default_fieldsetting).Updated Documentation can be found here: PPL Relevance Functions
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.