[PPL] Patterns command add UUID regex into log template parsing #3989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Contributor
Author
|
@songkant-aws can you help to review? |
Contributor
|
@Hailong-am LGTM. Please also make sure you verified the expected result on your test log data. @qianheng-aws @LantaoJin Could you help approve and merge it? |
Contributor
|
Minor: spotless check failed |
Contributor
Author
fixed |
songkant-aws
approved these changes
Aug 6, 2025
qianheng-aws
previously approved these changes
Aug 6, 2025
qianheng-aws
added
enhancement
LantaoJin
reviewed
Aug 8, 2025
Member
LantaoJin
left a comment
LantaoJin
left a comment
There was a problem hiding this comment.
Any IT for this change? And could you also update user doc patterns.rst.
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Contributor
Author
IT added. For the doc |
songkant-aws
approved these changes
Aug 20, 2025
qianheng-aws
approved these changes
Aug 21, 2025
LantaoJin
approved these changes
Aug 21, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2025
* add UUID regex into template Signed-off-by: Hailong Cui <[email protected]> * fix spotless Signed-off-by: Hailong Cui <[email protected]> * add integration test Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 4a3b03a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuancu
pushed a commit
that referenced
this pull request
Aug 21, 2025
… (#4096) * add UUID regex into template * fix spotless * add integration test --------- (cherry picked from commit 4a3b03a) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add UUID regex into template parsing
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.