Add missing udfs in v3 #3957
Merged
Add missing udfs in v3 #3957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinyu Hao <[email protected]>
ishaoxy
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
yuancu
reviewed
Jul 31, 2025
core/src/main/java/org/opensearch/sql/expression/function/udf/math/CoshFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
yuancu
reviewed
Aug 1, 2025
core/src/main/java/org/opensearch/sql/calcite/utils/UserDefinedFunctionUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
yuancu
reviewed
Aug 4, 2025
| registerOperator(RAND, SqlStdOperatorTable.RAND); | ||
| registerOperator(ROUND, SqlStdOperatorTable.ROUND); | ||
| registerOperator(SIGN, SqlStdOperatorTable.SIGN); | ||
| registerOperator(SIGNUM, SqlStdOperatorTable.SIGN); |
Collaborator
There was a problem hiding this comment.
The return type of SqlStdOperatorTable.SIGN (ARG0) seems to be different with SIGNUM (INTEGER) described in the documentation.
Contributor
Author
There was a problem hiding this comment.
Now the behavior is exactly the same as the existing function sign. Let me keep these changes first.
core/src/main/java/org/opensearch/sql/expression/function/PPLBuiltinOperators.java
Outdated
Show resolved
Hide resolved
| PLUS_FUCTION: 'ADD'; | ||
| MINUS_FUCTION: 'SUBTRACT'; | ||
| STAR_FUNCTION: 'MULTIPLY'; | ||
| DIVIDE_FUNCTION: 'DIVIDE'; |
Collaborator
There was a problem hiding this comment.
I'm a little unsure about whether should we explicitly add these functions or keep them as is.
Contributor
Author
There was a problem hiding this comment.
I added them with reference to this issue #1339. If you think they are inappropriate, I can delete these functions.
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
LantaoJin
previously approved these changes
Aug 4, 2025
| }; | ||
| } | ||
|
|
||
| public static ImplementorUDF adaptMathFunctionToUDF( |
Member
There was a problem hiding this comment.
Can you add a Javadoc for this class?
Signed-off-by: Xinyu Hao <[email protected]>
LantaoJin
approved these changes
Aug 5, 2025
qianheng-aws
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some missing functions in v2 and v3.
Added related IT and doc.
Related Issues
Resolves #3898
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.