[BugFix] Fix incorrect push down for Sarg with nullAs is TRUE #3882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
qianheng-aws
added
bug
Signed-off-by: Heng Qian <[email protected]>
LantaoJin
approved these changes
Jul 16, 2025
penghuo
approved these changes
Jul 16, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-3882-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 56436d45b38cc70ca855e2c6f69164f637a8bc16
# Push it to GitHub
git push --set-upstream origin backport/backport-3882-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
Member
|
@qianheng-aws please manually backport it to 2.19-dev. |
7 tasks
qianheng-aws
added a commit
to qianheng-aws/sql
that referenced
this pull request
Jul 22, 2025
…arch-project#3882) * [BugFix] Fix incorrect push down for Sarg with nullAs is TRUE Signed-off-by: Heng Qian <[email protected]> * Add allow warning for 3570.xml Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 56436d4)
qianheng-aws
added a commit
to qianheng-aws/sql
that referenced
this pull request
Jul 22, 2025
…arch-project#3882) * [BugFix] Fix incorrect push down for Sarg with nullAs is TRUE Signed-off-by: Heng Qian <[email protected]> * Add allow warning for 3570.xml Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 56436d4) Signed-off-by: Heng Qian <[email protected]>
penghuo
pushed a commit
that referenced
this pull request
Jul 22, 2025
…llAs is TRUE (#3882) (#3907) * [BugFix] Fix incorrect push down for Sarg with nullAs is TRUE (#3882) * [BugFix] Fix incorrect push down for Sarg with nullAs is TRUE Signed-off-by: Heng Qian <[email protected]> * Add allow warning for 3570.xml Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 56436d4) Signed-off-by: Heng Qian <[email protected]> * Fix compiling Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix incorrect push down for Sarg with nullAs is TRUE
Before this PR,
PredicateAnalyzerignore the nullAs properties in Sarg and leads to incorrect results.Related Issues
Resolves #3881
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.