[Backport 2.19-dev] Add compare_ip operator udfs (#3821) #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ip_compare operator added Signed-off-by: Xinyu Hao <[email protected]> * only type checker issue left Signed-off-by: Xinyu Hao <[email protected]> * fix by modifying ip.sqlTypeName from OTHER to NULL in type checker Signed-off-by: Xinyu Hao <[email protected]> * fix less Signed-off-by: Xinyu Hao <[email protected]> * modify the CalcitePPLFunctionTypeTest text Signed-off-by: Xinyu Hao <[email protected]> * allow CalciteIPComparisonIT in CalciteNoPushdownIT Signed-off-by: Xinyu Hao <[email protected]> * Modify the signature description in udf Signed-off-by: Xinyu Hao <[email protected]> * fix some typing errors Signed-off-by: Xinyu Hao <[email protected]> * modify the udfs for better style Signed-off-by: Xinyu Hao <[email protected]> * Make IpComparisonOperators an inner enum of CompareIPFunction Signed-off-by: Yuanchun Shen <[email protected]> * modify registerOperator Signed-off-by: Xinyu Hao <[email protected]> * modify registerOperator Signed-off-by: Xinyu Hao <[email protected]> * add type checker for cidr Signed-off-by: Xinyu Hao <[email protected]> * add javadoc Signed-off-by: Xinyu Hao <[email protected]> * move switch case to the implement method Signed-off-by: Xinyu Hao <[email protected]> --------- Signed-off-by: Xinyu Hao <[email protected]> Signed-off-by: Yuanchun Shen <[email protected]> Co-authored-by: Yuanchun Shen <[email protected]> (cherry picked from commit 6c3efa1)
ishaoxy
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
ishaoxy
changed the title
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
LantaoJin
approved these changes
Jul 15, 2025
qianheng-aws
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip_compare operator added
only type checker issue left
fix by modifying ip.sqlTypeName from OTHER to NULL in type checker
fix less
modify the CalcitePPLFunctionTypeTest text
allow CalciteIPComparisonIT in CalciteNoPushdownIT
Modify the signature description in udf
fix some typing errors
modify the udfs for better style
Make IpComparisonOperators an inner enum of CompareIPFunction
modify registerOperator
modify registerOperator
add type checker for cidr
add javadoc
move switch case to the implement method
(cherry picked from commit 6c3efa1)
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.