Allow warning header for yaml test #3846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
qianheng-aws
added
bug
Signed-off-by: Heng Qian <[email protected]>
penghuo
approved these changes
Jul 9, 2025
Collaborator
penghuo
left a comment
penghuo
left a comment
There was a problem hiding this comment.
It should not impact DSL aggregation query.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
* Allow warning header for yaml test Signed-off-by: Heng Qian <[email protected]> * Allow warning header for all yaml tests Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 877835e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin
pushed a commit
that referenced
this pull request
Jul 22, 2025
* Allow warning header for yaml test * Allow warning header for all yaml tests --------- (cherry picked from commit 877835e) Signed-off-by: Heng Qian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow warning header for yaml test. Only see such failure for
3102.ymland3312.ymlso far.OpenSearchQueryRequest relies on
_idto preserve sort location for PIT search:sql/opensearch/src/main/java/org/opensearch/sql/opensearch/request/OpenSearchQueryRequest.java
Lines 195 to 197 in 74b4de0
However, OpenSearch has deprecated the sort or aggregation behavior on
id:https://github.com/opensearch-project/OpenSearch/blob/36c2d5930ab3c036f19760942f95ea4bdb126137/server/src/main/java/org/opensearch/index/mapper/IdFieldMapper.java#L84-L87
So it will has warning message in the header of response, but the reason why it's flakey remains unclear. This PR make it workaround by allowing this warning header in yaml test.
For long term consideration, this issue should be addressed by this one: #3064
Related Issues
Resolves #3845
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.