Fix IT and CI, revert alias change #3423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
penghuo
commented
Mar 13, 2025
| exclude 'org/opensearch/sql/security/**' | ||
|
|
||
| // TODO. Exclude Remote IT. | ||
| exclude 'org/opensearch/sql/calcite/remote/**' |
Collaborator
Author
There was a problem hiding this comment.
exclude remote IT for CI, add back when shadowJar problem solved.
penghuo
commented
Mar 13, 2025
| |-------+-----+-----------------------| | ||
| | Nogal | 28 | 32838 | | ||
| +-------+-----+-----------------------+ | ||
| +-------+-----+--------------+ |
Collaborator
Author
There was a problem hiding this comment.
This breaking IT make sense to me, it is align with Spark-SQL response.
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
LantaoJin
reviewed
Mar 14, 2025
| @Provides | ||
| public PPLService pplService( | ||
| QueryManager queryManager, QueryPlanFactory queryPlanFactory, Settings settings) { | ||
| public PPLService pplService(QueryManager queryManager, QueryPlanFactory queryPlanFactory) { |
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/opensearch-project/sql/pull/3405") |
Member
There was a problem hiding this comment.
Thanks, I will make some reverts
penghuo
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
ps48,
seankao-az and
ykmr1224
as code owners
LantaoJin
merged commit 211d3cf
into
opensearch-project:feature/calcite-engine
11 of 13 checks passed
penghuo
added a commit
that referenced
this pull request
Jun 16, 2025
* Revert alias change, Fix IT Signed-off-by: Peng Huo <[email protected]> * Fix spotlessCheck Signed-off-by: Peng Huo <[email protected]> * Revert development test Signed-off-by: Peng Huo <[email protected]> * Fix PPL Test Signed-off-by: Peng Huo <[email protected]> * license header Signed-off-by: Peng Huo <[email protected]> * Ignore flaky test Signed-off-by: Peng Huo <[email protected]> --------- Signed-off-by: Peng Huo <[email protected]> Signed-off-by: xinyual <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #3430
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.