Skip to content

[Backport 2.x] Remove backticks on by field in stats #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dai-chen merged 1 commit into from
Jun 26, 2023
Merged

[Backport 2.x] Remove backticks on by field in stats #1751

dai-chen merged 1 commit into from
Jun 26, 2023

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jun 16, 2023

Backport 7525bb1 from #1728

@joshuali925 @github-actions
Remove backticks on by field in stats (#1728)
e0741cf 
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 7525bb1)
@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Merging #1751 (e0741cf) into 2.x (a528031) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.x    #1751   +/-   ##
=========================================
  Coverage     97.34%   97.34%           
  Complexity     4410     4410           
=========================================
  Files           388      388           
  Lines         10940    10941    +1     
  Branches        773      773           
=========================================
+ Hits          10649    10650    +1     
  Misses          284      284           
  Partials          7        7
Flag Coverage Δ
sql-engine 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <100.00%> (ø)

@dai-chen dai-chen added the PPL Piped processing language label Jun 26, 2023
@dai-chen dai-chen merged commit 6532a10 into 2.x Jun 26, 2023
@github-actions github-actions bot deleted the backport/backport-1728-to-2.x branch June 26, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dai-chen dai-chen dai-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees

No one assigned

Labels

PPL Piped processing language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dai-chen @Yury-Fridlyand @joshuali925