Skip to content

Conversation

@GabeFernandez310
Copy link
Contributor

Description

Adds the str_to_date function to the SQL plugin. The function takes two arguments, an input string and a format string. The format string contains string format specifiers which describe how the characters in the input string are parsed to a DATETIME. Based off of MySQL, but differs in some areas due to the limitations of the plugin and Java's built-in DatetimeFormatter. Specifically, the format string used must exactly match the string being parsed, and any dates/times with 0 for the year/month/day will return NULL since these fields must be valid for Java LocalDate/LocalTime/LocalDatetime. The arguments must have enough information to build a DATE, TIME, or DATETIME.

Example:
SELECT str_to_date("May 1, 2013", "%M %d, %Y") -> 2013-05-01 00:00:00
SELECT str_to_date("9,23,11", "%h,%i,%s") -> 0001-01-01 09:23:11

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Added Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Empty Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Partially Working Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Up Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Unit Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Altered Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Reworked Implementation To Always Return Datetime

Signed-off-by: GabeFernandez310 <[email protected]>

* Addressed PR Comments

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Some Checkstyle Issues

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Supported Function Properties

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Unneeded Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation and Added IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Code Coverage and Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner March 10, 2023 16:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #1420 (f21517e) into main (6496692) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1420      +/-   ##
============================================
+ Coverage     98.39%   98.41%   +0.01%     
- Complexity     3716     3741      +25     
============================================
  Files           343      343              
  Lines          9160     9246      +86     
  Branches        582      596      +14     
============================================
+ Hits           9013     9099      +86     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.41% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...sql/expression/datetime/DateTimeFormatterUtil.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yury-Fridlyand Yury-Fridlyand added enhancement New feature or request SQL labels Mar 10, 2023
acarbonetto
acarbonetto previously approved these changes Mar 13, 2023
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yury-Fridlyand
Yury-Fridlyand previously approved these changes Mar 15, 2023
Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested review from Yury-Fridlyand and removed request for dai-chen and penghuo March 15, 2023 22:29
@dai-chen dai-chen merged commit 40336d4 into opensearch-project:main Mar 16, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1420-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 40336d4dd38bbd015564e03e4b16429b59c6412f
# Push it to GitHub
git push --set-upstream origin backport/backport-1420-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1420-to-2.x.

GabeFernandez310 added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 16, 2023
* Add `STR_TO_DATE` Function To The SQL Plugin.

* Added Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Empty Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Partially Working Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Up Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Unit Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Altered Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Reworked Implementation To Always Return Datetime

Signed-off-by: GabeFernandez310 <[email protected]>

* Addressed PR Comments

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Some Checkstyle Issues

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Supported Function Properties

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Unneeded Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation and Added IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Code Coverage and Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 40336d4)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 16, 2023
* Add `STR_TO_DATE` Function To The SQL Plugin.

* Added Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Empty Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Partially Working Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Up Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Unit Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Altered Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Reworked Implementation To Always Return Datetime

Signed-off-by: GabeFernandez310 <[email protected]>

* Addressed PR Comments

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Some Checkstyle Issues

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Supported Function Properties

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Unneeded Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation and Added IT Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Code Coverage and Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>

* Cleaned Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 40336d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants