Skip to content

Conversation

@GabeFernandez310
Copy link
Contributor

Description

Adds the support to the get_format function to the OpenSearch SQL Plugin for JIS, ISO, EUR, and INTERNAL formats for DATE, TIME, TIMESTAMP and DATETIME. It's implementation is aligned with the MySQL Documentation.

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner February 15, 2023 16:14
@GabeFernandez310 GabeFernandez310 marked this pull request as draft February 15, 2023 16:15
@GabeFernandez310 GabeFernandez310 force-pushed the integ-add-get_format-function-formats branch from 7f611e9 to f068442 Compare February 15, 2023 16:24
@GabeFernandez310 GabeFernandez310 marked this pull request as ready for review February 15, 2023 16:25
@dai-chen dai-chen added the enhancement New feature or request label Feb 16, 2023
@dai-chen dai-chen merged commit 672c72f into opensearch-project:main Feb 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2023
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 672c72f)
penghuo pushed a commit that referenced this pull request Feb 16, 2023
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 672c72f)

Co-authored-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants