Skip to content

Conversation

@penghuo
Copy link
Collaborator

@penghuo penghuo commented Dec 12, 2022

Signed-off-by: Peng Huo [email protected]

Description

  1. Change LIKE operator PATTERN to case-insensitive.
  2. Update docs for SQL and PPL.

Issues Resolved

#1156

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.76%. Comparing base (c5e8fc0) to head (10f9497).
⚠️ Report is 454 commits behind head on 2.x.

❌ Your project status has failed because the head coverage (62.76%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (c5e8fc0) and HEAD (10f9497). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c5e8fc0) HEAD (10f9497)
sql-engine 2 0
Additional details and impacted files
@@              Coverage Diff              @@
##                2.x    #1160       +/-   ##
=============================================
- Coverage     98.31%   62.76%   -35.55%     
=============================================
  Files           342       10      -332     
  Lines          8700      658     -8042     
  Branches        554      119      -435     
=============================================
- Hits           8553      413     -8140     
- Misses          142      192       +50     
- Partials          5       53       +48     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Peng Huo <[email protected]>
@penghuo penghuo marked this pull request as ready for review December 12, 2022 22:23
@penghuo penghuo requested a review from a team as a code owner December 12, 2022 22:23
@penghuo penghuo added the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 12, 2022
@penghuo penghuo changed the title change case-insensitive to false Change LIKE operator case-insensitive match Dec 12, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@penghuo penghuo merged commit f8fbef7 into opensearch-project:2.x Dec 12, 2022
YANG-DB added a commit to YANG-DB/sql that referenced this pull request Dec 12, 2022
Change LIKE operator case-insensitive match (opensearch-project#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2.5.0 'Issues and PRs related to version v2.5.0'

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants