Skip to content

Conversation

@reta
Copy link
Contributor

@reta reta commented Dec 8, 2022

Signed-off-by: Andriy Redko [email protected]

Description

The distribution builds [1] are failing with:

Execution failed for task ':opensearch-sql-plugin:compileJava'.
> Could not resolve all dependencies for configuration ':opensearch-sql-plugin:compileClasspath'.
   > Conflict(s) found for the following module(s):
       - com.fasterxml.jackson.dataformat:jackson-dataformat-smile between versions 2.14.1 and 2.13.4
       - com.fasterxml.jackson.dataformat:jackson-dataformat-yaml between versions 2.14.1 and 2.13.4
     Run with:
         --scan or
         :opensearch-sql-plugin:dependencyInsight --configuration compileClasspath --dependency com.fasterxml.jackson.dataformat:jackson-dataformat-smile
     to get more insight on how to solve the conflict.

[1] https://build.ci.opensearch.org/job/distribution-build-opensearch/6673/console

Issues Resolved

Closes #1148

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner December 8, 2022 18:20
@dai-chen dai-chen added the dependencies Pull requests that update a dependency file label Dec 8, 2022
@reta
Copy link
Contributor Author

reta commented Dec 8, 2022

Ah ... missed integ_test module, it also forces resolution ....

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.80%. Comparing base (2af7321) to head (bd499a3).
⚠️ Report is 456 commits behind head on 2.x.

❌ Your project status has failed because the head coverage (95.80%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1150      +/-   ##
============================================
- Coverage     98.30%   95.80%   -2.51%     
  Complexity     3518     3518              
============================================
  Files           342      352      +10     
  Lines          8694     9352     +658     
  Branches        554      673     +119     
============================================
+ Hits           8547     8960     +413     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penghuo penghuo merged commit c5e8fc0 into opensearch-project:2.x Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] OS distribution 2.3.1 failed to build on SQL

6 participants