Skip to content

Conversation

@forestmvey
Copy link
Collaborator

Description

Add support for alternative syntax of MULTI_MATCH relevance search functions. Legacy engine supports parameter keys as quoted, or unquoted values for both required and optional arguments. This syntax has been ported over to all relevance functions in the V2 engine.

Example Queries

SELECT * FROM stackexchange_beer WHERE MULTI_MATCH('query'='cicerone', 'fields'='Tags');
SELECT * FROM stackexchange_beer WHERE MULTIMATCH('query'='cicerone', 'fields'='Tags');
SELECT * FROM stackexchange_beer WHERE MULTIMATCHQUERY('query'='cicerone', fields='Tags');
SELECT * FROM stackexchange_beer WHERE MULTIMATCHQUERY(query='cicerone', 'fields'=['Title,Tags^2.0']);

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@forestmvey forestmvey requested a review from a team as a code owner November 24, 2022 17:13
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.80%. Comparing base (43ceda1) to head (bf863a2).
⚠️ Report is 464 commits behind head on 2.x.

❌ Your project status has failed because the head coverage (95.80%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1102      +/-   ##
============================================
- Coverage     98.30%   95.80%   -2.50%     
- Complexity     3470     3479       +9     
============================================
  Files           348      358      +10     
  Lines          8659     9347     +688     
  Branches        549      674     +125     
============================================
+ Hits           8512     8955     +443     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penghuo
Copy link
Collaborator

penghuo commented Nov 28, 2022

please helping update doc

@forestmvey forestmvey force-pushed the integ-add-alternate-multi-match-syntax branch from 523f974 to bf863a2 Compare December 6, 2022 16:07
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen merged commit b76a178 into opensearch-project:2.x Dec 6, 2022
@dai-chen dai-chen added the enhancement New feature or request label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants