Skip to content

Conversation

@penghuo
Copy link
Collaborator

@penghuo penghuo commented Nov 23, 2022

Description

  1. Support opensearch-sql:run
  2. Update developer_guide doc. add prometheus and filesystem description.
  3. Add .java-version to .gitignore

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner November 23, 2022 22:08
@penghuo penghuo self-assigned this Nov 23, 2022
@penghuo penghuo added the maintenance Improves code quality, but not the product label Nov 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (42143b9) to head (e52d905).
⚠️ Report is 472 commits behind head on 2.x.

❌ Your project status has failed because the head coverage (95.78%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1099      +/-   ##
============================================
- Coverage     98.29%   95.78%   -2.52%     
  Complexity     3465     3465              
============================================
  Files           347      357      +10     
  Lines          8645     9303     +658     
  Branches        550      669     +119     
============================================
+ Hits           8498     8911     +413     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@MaxKsyunz MaxKsyunz merged commit 50669eb into opensearch-project:2.x Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improves code quality, but not the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants