-
Notifications
You must be signed in to change notification settings - Fork 180
Add cbrt function to the PPL #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cbrt function to the PPL #1097
Conversation
* Add cbrt function to the PPL Signed-off-by: Margarit Hakobyan <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (95.78%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 2.x #1097 +/- ##
============================================
- Coverage 98.28% 95.78% -2.51%
- Complexity 3454 3465 +11
============================================
Files 345 357 +12
Lines 8588 9305 +717
Branches 547 669 +122
============================================
+ Hits 8441 8913 +472
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
integ-test/src/test/java/org/opensearch/sql/ppl/MathematicalFunctionIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: Margarit Hakobyan <[email protected]>
dai-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Signed-off-by: Margarit Hakobyan [email protected]
Description
Calculates the cube root of a number
Argument type: INTEGER/LONG/FLOAT/DOUBLE
Return type DOUBLE:
(Non-negative) INTEGER/LONG/FLOAT/DOUBLE -> DOUBLE
(Negative) INTEGER/LONG/FLOAT/DOUBLE -> DOUBLE
Example::
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.