[Backport 2.4] Fix incorrect results returned by min, max and avg
#1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix incorrect results returned by `min`, `max` and `avg` aggregations on null/missing values. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix indentation. Signed-off-by: Yury-Fridlyand <[email protected]> * Activate and fix integration tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Add more tests. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 4282450)
Codecov Report
@@ Coverage Diff @@
## 2.4 #1022 +/- ##
============================================
- Coverage 98.26% 95.68% -2.58%
- Complexity 3325 3326 +1
============================================
Files 324 334 +10
Lines 8399 9057 +658
Branches 553 672 +119
============================================
+ Hits 8253 8666 +413
- Misses 142 334 +192
- Partials 4 57 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yury-Fridlyand
approved these changes
Nov 3, 2022
dai-chen
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4282450 from #1000