Skip to content

Conversation

@Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury-Fridlyand [email protected]

Description

[temporary] Disable doctests which use ML-common plugin.

Issues Resolved

#915 (comment)
Unblocks #999

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner November 2, 2022 21:38
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Nov 2, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Could you open an issue to remind us to bring this back once AD team improves it from their side?

@Yury-Fridlyand
Copy link
Collaborator Author

Thanks for fixing this! Could you open an issue to remind us to bring this back once AD team improves it from their side?

#1013

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dai-chen dai-chen merged commit 1a52511 into opensearch-project:2.x Nov 3, 2022
dai-chen pushed a commit that referenced this pull request Nov 3, 2022
…sts. (#1011)

Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand deleted the dev-deactivate-ml-doctests branch November 16, 2022 00:35
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 7, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants