Skip to content

Conversation

@Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Oct 23, 2025

Description

Lots of hacky changes, going to be adding some docs and seeing what it'd take to finalize these. Let's merge these initial fixes quickly and figure out long-term changes later.

Exact list of changes:

  • Updated Sonatype location to new S3 repository
  • Changed the default version from 3.1 to 3.3 (TODO: auto-use the latest)
  • Locks the opensearch-java client version to 3.2 (should be independent of OS since it's a client, and it causes issues to keep it in sync since it has a different release cadence).
  • Implements a new RestClientImpl method (since it was added to the interface in SQL)
  • Fixes some mismatches with some sources expecting 4 digits in a version (SQL plugin jars all need 3_3_0_0) while others need 3 digits (org.opensearch:opensearch needs 3.3.0)
  • Link updates (for Lychee), @vamsimanohar's username change continues to be annoying ;)

For the long term, we need to:

  • Remove hardcoded references to 3.3, just use the latest version by default
  • Figure out some sort of tests to lock our SQL interfaces in place (such as the ClientImpl here)

Issues Resolved

CLI doesn't build with 3.3

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis merged commit 6f5dba5 into opensearch-project:main Oct 24, 2025
5 checks passed
@Swiddis Swiddis deleted the bugfix/3.3-fixes branch October 24, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants