Skip to content

Prevent hidden roles from being added via rolesmapping and internalus…#614

Merged
debjanibnrj merged 1 commit intoopensearch-project:masterfrom
debjanibnrj:opendistro-superadmin_roles
Aug 3, 2020
Merged

Prevent hidden roles from being added via rolesmapping and internalus…#614
debjanibnrj merged 1 commit intoopensearch-project:masterfrom
debjanibnrj:opendistro-superadmin_roles

Conversation

@debjanibnrj
Copy link
Contributor

@debjanibnrj debjanibnrj commented Aug 3, 2020

…ers API

Issue #, if available:
Addresses issues -
https://github.com/opendistro-for-elasticsearch/security/issues/601 and https://github.com/opendistro-for-elasticsearch/security/issues/590

This issue also contains changes requested in https://github.com/opendistro-for-elasticsearch/security/pull/595.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #614 into master will increase coverage by 0.02%.
The diff coverage is 85.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #614      +/-   ##
============================================
+ Coverage     63.12%   63.14%   +0.02%     
- Complexity     3044     3050       +6     
============================================
  Files           233      233              
  Lines         16550    16562      +12     
  Branches       2986     2990       +4     
============================================
+ Hits          10447    10458      +11     
  Misses         4552     4552              
- Partials       1551     1552       +1     
Impacted Files Coverage Δ Complexity Δ
.../security/dlic/rest/api/RolesMappingApiAction.java 86.36% <78.57%> (-13.64%) 9.00 <2.00> (+2.00) ⬇️
...arch/security/dlic/rest/api/AbstractApiAction.java 75.91% <91.66%> (+0.81%) 65.00 <4.00> (+4.00)
...security/dlic/rest/api/InternalUsersApiAction.java 86.11% <100.00%> (-1.70%) 24.00 <0.00> (-2.00)
...security/configuration/DlsFlsFilterLeafReader.java 58.16% <0.00%> (-0.75%) 58.00% <0.00%> (ø%)
...search/security/tools/OpenDistroSecurityAdmin.java 47.52% <0.00%> (+0.26%) 77.00% <0.00%> (+1.00%)
...icsearch/security/compliance/ComplianceConfig.java 79.86% <0.00%> (+1.09%) 49.00% <0.00%> (ø%)
...icsearch/security/auditlog/config/AuditConfig.java 98.85% <0.00%> (+2.22%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff00f4f...56c9407. Read the comment docs.

@debjanibnrj debjanibnrj requested a review from a team August 3, 2020 18:36
@debjanibnrj debjanibnrj merged commit 480ef0b into opensearch-project:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants