Skip to content

Conversation

@finnegancarroll
Copy link
Contributor

@finnegancarroll finnegancarroll commented Aug 5, 2025

Description

Pending core change: opensearch-project/OpenSearch#18915
gRPC transport is moving out of experimental in core. Settings in ITs need to reflect this change.

Issues Resolved

N/A

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

Unit/Integration tests

Testing plugin install step locally with the following:

export SNAP_VERSION=3.2.0
export PLAT=darwin
export REPOS_DIR=<security and OS repos path>

export OS_REPO=${REPOS_DIR}OpenSearch
export SEC_REPO=${REPOS_DIR}security
export SEC_TAR=${SEC_REPO}/build/distributions/opensearch-security-${SNAP_VERSION}.0-SNAPSHOT.zip
export OS_INSTALL=${OS_REPO}/distribution/archives/${PLAT}-tar/build/install/opensearch-${SNAP_VERSION}-SNAPSHOT

cd ${OS_REPO} && ./gradlew :distribution:archives:${PLAT}-tar:assemble 
cd ${SEC_REPO} && ./gradlew :assemble

${OS_INSTALL}/bin/opensearch-plugin install file://${SEC_TAR}

# Create demo certs - Respond yes yes no - Keep cluster mode disabled
export OPENSEARCH_INITIAL_ADMIN_PASSWORD=PrTestPass369char! && \
chmod +x "${OS_INSTALL}/plugins/opensearch-security/tools/install_demo_configuration.sh" && \
"${OS_INSTALL}/plugins/opensearch-security/tools/install_demo_configuration.sh"

${OS_INSTALL}/bin/opensearch

Seeing single process start with no issue:

[2025-08-05T13:18:03,641][INFO ][o.o.c.r.a.AllocationService] [6cb1339d7f79] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[security-auditlog-2025.08.05][0]]]).

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finnegancarroll We should add a changelog that shows that we update the setting.

Nvm, this is a test file-only change

… need to reflect this change in settings.

Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Copy link
Contributor Author

@finnegancarroll We should add a changelog that shows that we update the setting.

gRPC is currently a test only dependency on this repo. End users should have no visibility in this so I was thinking changelog entry would not be appropriate here.

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (11c71e7) to head (dc9201d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5542      +/-   ##
==========================================
- Coverage   72.93%   72.93%   -0.01%     
==========================================
  Files         399      400       +1     
  Lines       24924    24925       +1     
  Branches     3803     3803              
==========================================
  Hits        18179    18179              
- Misses       4897     4900       +3     
+ Partials     1848     1846       -2     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarshitChanpura
Copy link
Member

@finnegancarroll Can you take a look at CI failures?

Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Copy link
Contributor Author

@finnegancarroll Can you take a look at CI failures?

Waiting on opensearch-project/OpenSearch#18928

Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Copy link
Contributor Author

A problem occurred evaluating root project 'opensearch-security'.
> Failed to apply plugin class 'org.opensearch.gradle.info.GlobalBuildInfoPlugin'.
   > Gradle 8.14.3+ is required

Signed-off-by: Finn Carroll <[email protected]>
@DarshitChanpura DarshitChanpura changed the title Move gRPC transport out of experimental Bump gradle to 8.14.3 and move gRPC transport out of experimental Aug 5, 2025
@cwperks cwperks merged commit 58f693a into opensearch-project:main Aug 5, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants