-
Notifications
You must be signed in to change notification settings - Fork 341
Bump gradle to 8.14.3 and move gRPC transport out of experimental #5542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gradle to 8.14.3 and move gRPC transport out of experimental #5542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@finnegancarroll We should add a changelog that shows that we update the setting.
Nvm, this is a test file-only change
… need to reflect this change in settings. Signed-off-by: Finn Carroll <[email protected]>
gRPC is currently a test only dependency on this repo. End users should have no visibility in this so I was thinking changelog entry would not be appropriate here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5542 +/- ##
==========================================
- Coverage 72.93% 72.93% -0.01%
==========================================
Files 399 400 +1
Lines 24924 24925 +1
Branches 3803 3803
==========================================
Hits 18179 18179
- Misses 4897 4900 +3
+ Partials 1848 1846 -2 🚀 New features to boost your workflow:
|
|
@finnegancarroll Can you take a look at CI failures? |
Signed-off-by: Finn Carroll <[email protected]>
d409b68 to
208f493
Compare
Signed-off-by: Finn Carroll <[email protected]>
Waiting on opensearch-project/OpenSearch#18928 |
Signed-off-by: Finn Carroll <[email protected]>
|
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Description
Pending core change: opensearch-project/OpenSearch#18915
gRPC transport is moving out of experimental in core. Settings in ITs need to reflect this change.
Issues Resolved
N/A
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
Unit/Integration tests
Testing plugin install step locally with the following:
Seeing single process start with no issue:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.