-
Notifications
You must be signed in to change notification settings - Fork 343
Handle subject in nested claim for JWT auth backends #5467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle subject in nested claim for JWT auth backends #5467
Conversation
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
…eClaimName. Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5467 +/- ##
==========================================
- Coverage 72.78% 72.75% -0.03%
==========================================
Files 398 398
Lines 24641 24657 +16
Branches 3747 3752 +5
==========================================
+ Hits 17934 17939 +5
- Misses 4878 4885 +7
- Partials 1829 1833 +4
🚀 New features to boost your workflow:
|
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
Signed-off-by: Rishav Kumar <[email protected]>
cwperks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @Rishav9852Kumar ! The changes LGTM.
src/integrationTest/java/org/opensearch/security/http/JwtAuthorizationHeaderFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishav Kumar <[email protected]>
shikharj05
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rishav9852Kumar !
…ect#5467) Signed-off-by: Rishav Kumar <[email protected]> Co-authored-by: Rishav Kumar <[email protected]>
Description
This PR abstracts the
subjectconfiguration from jwt-backed auth backends to handle a list as config to get sub within nested claims of a JWT payload.Enhancement of #5355
Issues Resolved
Resolves #5430
Supported Nested claims
Testing
Unit Tests added
Added in
HTTPJwtKeyByOpenIdConnectAuthenticatorTestInteg Tests added
Added in
JwtAuthenticationNestedClaimsTestsCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.