[2.19] Quick fix for tenant privilege performance issues #5368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minimal quick fix to solve the performance issues described in #5342 and #5129 also for OpenSearch 2.19.
It won't be as fast as the implementation in #5350, as it still requires loops. Still, micro benchmarks on
ConfigModelV7.mapTenants()show a huge improvement (10 threads, 10000 iterations):This can be achieved by avoiding calls to
SecurityDynamicConfiguration.getCEntries()which will always copy the configHashMapin a synchronized block - thus very strongly limiting the concurrency on the particular node.Issues Resolved
Fixes #5342
Fixes #5129
Related fix for 3.0: #5350
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.