Skip to content

Conversation

@willyborankin
Copy link
Collaborator

@willyborankin willyborankin commented Apr 8, 2025

Description

Added additional unit test for the #4949 issue

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.98%. Comparing base (55a4220) to head (6869ecc).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5256      +/-   ##
==========================================
+ Coverage   71.91%   71.98%   +0.06%     
==========================================
  Files         378      378              
  Lines       23562    23560       -2     
  Branches     3630     3629       -1     
==========================================
+ Hits        16945    16959      +14     
+ Misses       4811     4794      -17     
- Partials     1806     1807       +1     
Files with missing lines Coverage Δ
...rch/security/ssl/config/KeyStoreConfiguration.java 66.66% <100.00%> (-0.87%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@willyborankin willyborankin force-pushed the validate-certs-in-chain branch from e6220e2 to 911e5d4 Compare April 10, 2025 15:12
@willyborankin willyborankin force-pushed the validate-certs-in-chain branch 2 times, most recently from e2e321b to 663d909 Compare May 24, 2025 20:44
@willyborankin willyborankin changed the title Only check validity of certs in the chain of the node certificates Additional unit test for #4949 May 24, 2025
@willyborankin willyborankin marked this pull request as ready for review May 24, 2025 21:20
Added additional unit test for the opensearch-project#4949 issue

Signed-off-by: Andrey Pleskach <[email protected]>
@willyborankin willyborankin force-pushed the validate-certs-in-chain branch from 663d909 to 6869ecc Compare May 25, 2025 18:29
@shikharj05 shikharj05 merged commit a1717ee into opensearch-project:main May 26, 2025
70 checks passed
@cwperks
Copy link
Member

cwperks commented May 26, 2025

TY for adding a test for this that does not rely on hardcoded certs!

@willyborankin willyborankin deleted the validate-certs-in-chain branch July 6, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants